Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(281)

Side by Side Diff: blimp/engine/mojo/blob_channel.mojom

Issue 2056993003: Add Mojo IPC for seeding new Renderer with Browser's cached blob state. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@blobchannel-master
Patch Set: use a better upstream branch for the patch Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 module blimp.engine.mojom; 5 module blimp.engine.mojom;
6 6
7 struct CacheStateEntry {
8 // The non-human-readable ID of the cache item.
Wez 2016/06/21 00:33:33 nit: Is it relevant that it's not human-readable?
Kevin M 2016/06/21 21:23:51 I think so. We convert this ID to hex for logging,
Wez 2016/06/22 19:54:23 Hmmm; I'd argue that BlobId is intrinsically binar
9 string id;
10
11 // True if the cached item exists on the remote end of the BlobChannel.
12 bool is_replicated;
Wez 2016/06/21 00:33:33 was_delivered, to match the terminology below?
Kevin M 2016/06/21 21:23:51 Done.
13 };
14
7 interface BlobChannel { 15 interface BlobChannel {
16 // Gets the list of cache keys and their replication status in the
17 // browser process' BlobCache.
18 GetCacheState() => (array<CacheStateEntry> items);
Wez 2016/06/21 00:33:33 You're calling this CacheStateEntry but then the p
Kevin M 2016/06/21 21:23:51 Done.
19
8 // Stores the blob |id| in the BlobCache. 20 // Stores the blob |id| in the BlobCache.
9 // TODO(kmarshall): Use shared memory for more efficient data transfer, see 21 // TODO(kmarshall): Use shared memory for more efficient data transfer, see
10 // crbug.com/614564 . 22 // crbug.com/614564 .
11 PutBlob(string id, string data); 23 PutBlob(string id, string data);
12 24
13 // Requests that the BlobChannel push the blob |id| over the wire. 25 // Requests that the BlobChannel push the blob |id| over the wire.
14 // The request will be ignored if the BlobChannel knows that 26 // The request will be ignored if the BlobChannel knows that
15 // the client already has the data. 27 // the client already has the data.
16 DeliverBlob(string id); 28 DeliverBlob(string id);
17 }; 29 };
18 30
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698