Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Side by Side Diff: content/browser/cache_storage/cache_storage_cache_handle.cc

Issue 2056983004: [CacheStorage] Give ownership of all CacheStorageCaches to CacheStorage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Self review Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
(Empty)
1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "content/browser/cache_storage/cache_storage_cache_handle.h"
6
7 namespace content {
8
9 CacheStorageCacheHandle::~CacheStorageCacheHandle() {
10 if (cache_storage_ && cache_storage_cache_)
11 cache_storage_->DropCacheHandleRef(cache_storage_cache_.get());
12 }
13
14 std::unique_ptr<CacheStorageCacheHandle> CacheStorageCacheHandle::Clone() {
15 return std::unique_ptr<CacheStorageCacheHandle>(
16 new CacheStorageCacheHandle(cache_storage_cache_, cache_storage_));
17 }
18
19 CacheStorageCacheHandle::CacheStorageCacheHandle(
20 base::WeakPtr<CacheStorageCache> cache_storage_cache,
21 base::WeakPtr<CacheStorage> cache_storage)
22 : cache_storage_cache_(cache_storage_cache), cache_storage_(cache_storage) {
23 DCHECK(cache_storage);
24 DCHECK(cache_storage_cache_);
25 if (cache_storage_cache_)
nhiroki 2016/06/14 05:30:24 We should not handle the DCHECK failure case: "A
jkarlin 2016/06/14 06:41:08 Good catch, thanks! Done.
26 cache_storage_->AddCacheHandleRef(cache_storage_cache_.get());
27 }
28
29 } // namespace content
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698