[CacheStorage] Give ownership of all CacheStorageCaches to CacheStorage

content/browser/cache_storage/cache_storage_unittest.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "content/browser/cache_storage/cache_storage.h"
 
 #include "base/bind.h"
 #include "base/callback.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/memory/ref_counted.h"
 #include "base/run_loop.h"
 #include "base/stl_util.h"
 #include "base/threading/thread_task_runner_handle.h"
+#include "content/browser/cache_storage/cache_storage_cache_handle.h"
 #include "content/browser/quota/mock_quota_manager_proxy.h"
 #include "content/public/test/mock_special_storage_policy.h"
 #include "content/public/test/test_browser_thread_bundle.h"
 #include "net/url_request/url_request_context_getter.h"
 #include "storage/browser/quota/quota_manager_proxy.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace content {
 
 namespace {
@@ skipping 65 matching lines @@
     bool callback_called = false;
     test_cache_storage_->OpenCache(
         cache_name, base::Bind(&CacheStorageTest::OpenCacheCallback,
                                base::Unretained(this), &callback_called));
     base::RunLoop().RunUntilIdle();
     EXPECT_TRUE(callback_called);
     return callback_error_ == CACHE_STORAGE_OK;
   }
 
   void OpenCacheCallback(bool* callback_called,
-                         scoped_refptr<CacheStorageCache> cache,
+                         std::unique_ptr<CacheStorageCacheHandle> cache_handle,
                          CacheStorageError error) {
     *callback_called = true;
-    callback_cache_ = cache;
+    callback_cache_handle_ = std::move(cache_handle);
     callback_error_ = error;
   }
 
   base::ScopedTempDir temp_dir_;
   TestBrowserThreadBundle browser_thread_bundle_;
   scoped_refptr<MockSpecialStoragePolicy> quota_policy_;
   scoped_refptr<MockQuotaManager> mock_quota_manager_;
   scoped_refptr<MockQuotaManagerProxy> quota_manager_proxy_;
   std::unique_ptr<TestCacheStorage> test_cache_storage_;
 
-  scoped_refptr<CacheStorageCache> callback_cache_;
+  std::unique_ptr<CacheStorageCacheHandle> callback_cache_handle_;
   CacheStorageError callback_error_;
 };
 
 TEST_F(CacheStorageTest, PreserveCache) {
   test_cache_storage_->set_delay_preserved_cache_callback(true);
   EXPECT_TRUE(OpenCache("foo"));
-  EXPECT_TRUE(test_cache_storage_->IsPreservingCache(callback_cache_.get()));
+  EXPECT_TRUE(
+      test_cache_storage_->IsPreservingCache(callback_cache_handle_->value()));
   test_cache_storage_->RunPreservedCacheCallback();
-  EXPECT_FALSE(test_cache_storage_->IsPreservingCache(callback_cache_.get()));
+  EXPECT_FALSE(
+      test_cache_storage_->IsPreservingCache(callback_cache_handle_->value()));
 
-  // Try opening it again, since the cache is already open (callback_cache_ is
-  // referencing it) the cache shouldn't be preserved again.
+  // Try opening it again, since the cache is already open
+  // (callback_cache_handle_ is referencing it) the cache shouldn't be preserved
+  // again.
   EXPECT_TRUE(OpenCache("foo"));
-  EXPECT_FALSE(test_cache_storage_->IsPreservingCache(callback_cache_.get()));
+  EXPECT_FALSE(
+      test_cache_storage_->IsPreservingCache(callback_cache_handle_->value()));
 
   // Remove the reference to the cache so that it's deleted. After that, the
   // next time it's opened will require the cache to be created again and
   // preserved.
-  callback_cache_ = nullptr;
+  callback_cache_handle_.reset();
   EXPECT_TRUE(OpenCache("foo"));
-  EXPECT_TRUE(test_cache_storage_->IsPreservingCache(callback_cache_.get()));
+  EXPECT_TRUE(
+      test_cache_storage_->IsPreservingCache(callback_cache_handle_->value()));
   test_cache_storage_->RunPreservedCacheCallback();
-  EXPECT_FALSE(test_cache_storage_->IsPreservingCache(callback_cache_.get()));
+  EXPECT_FALSE(
+      test_cache_storage_->IsPreservingCache(callback_cache_handle_->value()));
 }
 
 }  // namespace content