Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(23)

Issue 2056913002: Fix a message bug. (Closed)

Created:
4 years, 4 months ago by nweiz
Modified:
4 years, 4 months ago
Reviewers:
Jennifer Messerly
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/source_span@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a message bug. If a point span appeared past the end of a file, and that file *didn't* end with a trailing newline, that span would be printed as though it pointed at the last character of the file. R=jmesserly@google.com Committed: https://github.com/dart-lang/source_span/commit/202b0efa76676c1a2abcd97176a446407bab5ecf

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -2 lines) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/span_mixin.dart View 1 chunk +1 line, -1 line 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/file_message_test.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
nweiz
4 years, 4 months ago (2016-06-09 22:07:33 UTC) #1
Jennifer Messerly
LGTM!
4 years, 4 months ago (2016-06-09 22:31:34 UTC) #2
nweiz
4 years, 4 months ago (2016-06-09 22:37:47 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
202b0efa76676c1a2abcd97176a446407bab5ecf (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698