Remove Registry from registerMetadataConstant

Remove Registry from registerMetadataConstant

Avoids registration of metadata from within resolution.
This prepares for handling deserialized metadata.

R=het@google.com

Committed: https://github.com/dart-lang/sdk/commit/ed1777e4b26643099ef0c24cd53d5c1629850141

Reverted: https://github.com/dart-lang/sdk/commit/368d4d54d3634cfbbbfcf63bce8d024dd7b9a4ae
Committed: https://github.com/dart-lang/sdk/commit/34bab63be2d78f67d12eec0bf60b2ef520456896

[Johnni Winther, 2016-06-10 11:58:19]

johnniwinther@google.com changed reviewers:
+ het@google.com

[Johnni Winther, 2016-06-10 11:58:19]

https://codereview.chromium.org/2056903003/diff/1/pkg/compiler/lib/src/js_bac...
File pkg/compiler/lib/src/js_backend/backend.dart (left):

https://codereview.chromium.org/2056903003/diff/1/pkg/compiler/lib/src/js_bac...
pkg/compiler/lib/src/js_backend/backend.dart:1061:
registerCompileTimeConstant(constant, registry);
This isn't needed since we will call it from [onQueueEmpty] anyway, if metadata
is needed.

[Johnni Winther, 2016-06-15 07:35:58]

ping

[Harry Terkelsen, 2016-06-15 17:54:34]

lgtm

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2352: // elements and process these
instead.
can this be moved to onQueueEmpty?

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2353:
compiler.enqueuer.resolution.processedElements.forEach(processElementMetadata);
nit: long line

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_serialization.dart (right):

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_serialization.dart:7: import
'../common.dart';
are you using this import or was it just for debug?

[Johnni Winther, 2016-06-16 07:17:42]

Description was changed from

==========
Remove Registry from registerMetadataConstant

Avoids registration of metadata from within resolution.
This prepares for handling deserialized metadata.
==========

to

==========
Remove Registry from registerMetadataConstant

Avoids registration of metadata from within resolution.
This prepares for handling deserialized metadata.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed1777e4b26643099ef0c24cd53d5c1629850141
==========

[Johnni Winther, 2016-06-16 07:17:43]

Committed patchset #5 (id:70008) manually as
ed1777e4b26643099ef0c24cd53d5c1629850141 (presubmit successful).

[Johnni Winther, 2016-06-16 07:18:22]

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend.dart (right):

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2352: // elements and process these
instead.
On 2016/06/15 17:54:34, Harry Terkelsen wrote:
> can this be moved to onQueueEmpty?

Done.

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend.dart:2353:
compiler.enqueuer.resolution.processedElements.forEach(processElementMetadata);
On 2016/06/15 17:54:34, Harry Terkelsen wrote:
> nit: long line

Done.

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_backend/backend_serialization.dart (right):

https://codereview.chromium.org/2056903003/diff/40001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_backend/backend_serialization.dart:7: import
'../common.dart';
On 2016/06/15 17:54:34, Harry Terkelsen wrote:
> are you using this import or was it just for debug?

Just for debugging. Removed.

[Johnni Winther, 2016-06-16 08:14:30]

Description was changed from

==========
Remove Registry from registerMetadataConstant

Avoids registration of metadata from within resolution.
This prepares for handling deserialized metadata.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed1777e4b26643099ef0c24cd53d5c1629850141
==========

to

==========
Remove Registry from registerMetadataConstant

Avoids registration of metadata from within resolution.
This prepares for handling deserialized metadata.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed1777e4b26643099ef0c24cd53d5c1629850141

Reverted:
https://github.com/dart-lang/sdk/commit/368d4d54d3634cfbbbfcf63bce8d024dd7b9a4ae
==========

[Johnni Winther, 2016-06-16 10:04:44]

Description was changed from

==========
Remove Registry from registerMetadataConstant

Avoids registration of metadata from within resolution.
This prepares for handling deserialized metadata.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed1777e4b26643099ef0c24cd53d5c1629850141

Reverted:
https://github.com/dart-lang/sdk/commit/368d4d54d3634cfbbbfcf63bce8d024dd7b9a4ae
==========

to

==========
Remove Registry from registerMetadataConstant

Avoids registration of metadata from within resolution.
This prepares for handling deserialized metadata.

R=het@google.com

Committed:
https://github.com/dart-lang/sdk/commit/ed1777e4b26643099ef0c24cd53d5c1629850141

Reverted:
https://github.com/dart-lang/sdk/commit/368d4d54d3634cfbbbfcf63bce8d024dd7b9a4ae
Committed:
https://github.com/dart-lang/sdk/commit/34bab63be2d78f67d12eec0bf60b2ef520456896
==========

[Johnni Winther, 2016-06-16 10:04:45]

Committed patchset #7 (id:110001) manually as
34bab63be2d78f67d12eec0bf60b2ef520456896 (presubmit successful).

[Johnni Winther, 2016-06-16 10:06:21]

PTAL at the last patch (post commit)

[Harry Terkelsen, 2016-06-16 17:52:42]

lgtm