Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 2056833003: Remove unnecessary use of CrossThreadPersistent<>. (Closed)

Created:
4 years, 6 months ago by sof
Modified:
4 years, 6 months ago
Reviewers:
oilpan-reviews, haraken
CC:
chromium-reviews, blink-reviews, mlamouri+watch-blink_chromium.org, kinuko+watch, dcheng
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unnecessary use of CrossThreadPersistent<>. The CompositorMutatorImpl object that WebFrameWidgetImpl creates and controls the lifetime of, should be referenced as a normal Member<> R= BUG= Committed: https://crrev.com/64d9377e8c194ef2c5dc12c836620b9924a9af5b Cr-Commit-Position: refs/heads/master@{#399125}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M third_party/WebKit/Source/web/WebFrameWidgetImpl.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/web/WebFrameWidgetImpl.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 11 (3 generated)
sof
please take a look.
4 years, 6 months ago (2016-06-09 21:10:03 UTC) #2
haraken
But this is a cross-thread reference, right? keishi@ is planning to replace cross-thread references with ...
4 years, 6 months ago (2016-06-09 23:34:26 UTC) #3
sof
On 2016/06/09 23:34:26, haraken wrote: > But this is a cross-thread reference, right? keishi@ is ...
4 years, 6 months ago (2016-06-10 05:12:53 UTC) #4
haraken
On 2016/06/10 05:12:53, sof wrote: > On 2016/06/09 23:34:26, haraken wrote: > > But this ...
4 years, 6 months ago (2016-06-10 05:21:21 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056833003/1
4 years, 6 months ago (2016-06-10 06:30:21 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 06:46:46 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/64d9377e8c194ef2c5dc12c836620b9924a9af5b Cr-Commit-Position: refs/heads/master@{#399125}
4 years, 6 months ago (2016-06-10 06:49:01 UTC) #10
flackr
4 years, 6 months ago (2016-06-10 14:45:14 UTC) #11
Message was sent while issue was closed.
On 2016/06/10 at 05:12:53, sigbjornf wrote:
> On 2016/06/09 23:34:26, haraken wrote:
> > But this is a cross-thread reference, right? keishi@ is planning to replace
> > cross-thread references with CrossThreadPersistent when we enable the
per-thread
> > heap.
> 
> It's created, owned and passed to another object created on the main thread..?
If someone passes that to a compositor work, that would represent a cross-thread
pointer.

It is passed to the compositor thread through the WebLayerTreeView plumbing. It
is actually held indirectly by LayerTreeHostImpl's OwnPtr<LayerTreeMutator>
https://cs.chromium.org/chromium/src/cc/trees/layer_tree_host_impl.h?q=LayerT...
which holds a Persistent<CompositorMutator> of the CompositorMutatorImpl here:
https://cs.chromium.org/chromium/src/third_party/WebKit/Source/platform/graph...

Powered by Google App Engine
This is Rietveld 408576698