Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(676)

Issue 2056823002: mash: Move SystemTrayDelegate and dependencies to //ash/common (Closed)

Created:
4 years, 6 months ago by James Cook
Modified:
4 years, 6 months ago
Reviewers:
msw
CC:
chromium-reviews, sadrul, dtseng+watch_chromium.org, derat+watch_chromium.org, aboxhall+watch_chromium.org, achuith+watch_chromium.org, dzhioev+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, je_julie, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, kalyank, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mash: Move SystemTrayDelegate and dependencies to //ash/common These are dependencies of TrayUpdate, which I'm in the process of moving. Creates a new directory for update-related code, //ash/common/system/update. This is mostly a mechanical move: * move_source_file.py ash/system/tray/system_tray_delegate.h ash/common/system/tray/ * move_source_file.py ash/system/tray/system_tray_delegate.cc ash/common/system/tray/ * move_source_file.py ash/system/tray/default_system_tray_delegate.h ash/common/system/tray/ * move_source_file.py ash/system/tray/default_system_tray_delegate.cc ash/common/system/tray/ * move_source_file.py ash/system/user/update_observer.h ash/common/system/update/ * move_source_file.py ash/volume_control_delegate.h ash/common/system/ * move_source_file.py ash/networking_config_delegate.h ash/common/system/ * move_source_file.py ash/networking_config_delegate.cc ash/common/system/ Removes a couple of unnecessary includes along the way. BUG=615155 TEST=compiles TBR=sky@chromium.org for mechanical changes in //chrome Committed: https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7 Cr-Commit-Position: refs/heads/master@{#398990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -993 lines) Patch
M ash/accelerators/accelerator_controller.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_controller_unittest.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M ash/accelerators/accelerator_interactive_uitest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/ash.gyp View 6 chunks +8 lines, -8 lines 0 comments Download
A + ash/common/system/networking_config_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/networking_config_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/tray/default_system_tray_delegate.h View 2 chunks +4 lines, -5 lines 0 comments Download
A + ash/common/system/tray/default_system_tray_delegate.cc View 1 chunk +3 lines, -4 lines 0 comments Download
A + ash/common/system/tray/system_tray_delegate.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + ash/common/system/tray/system_tray_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
A + ash/common/system/update/update_observer.h View 2 chunks +3 lines, -3 lines 0 comments Download
A + ash/common/system/volume_control_delegate.h View 2 chunks +3 lines, -3 lines 0 comments Download
M ash/magnifier/magnification_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/metrics/user_metrics_recorder.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/networking_config_delegate.h View 1 chunk +0 lines, -45 lines 0 comments Download
D ash/networking_config_delegate.cc View 1 chunk +0 lines, -17 lines 0 comments Download
M ash/root_window_controller.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/root_window_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/shelf/shelf_widget.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/shell.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/shell/shell_delegate_impl.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/audio/tray_audio.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/cast/tray_cast.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/bluetooth/tray_bluetooth.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/brightness/tray_brightness_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/enterprise/tray_enterprise.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/network_state_list_detailed_view.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M ash/system/chromeos/network/tray_network.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/tray_vpn.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/network/vpn_list_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/dual_role_notification.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/power/tray_power.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/rotation/tray_rotation_lock_unittest.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/last_window_closed_logout_reminder.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/tray_session_length_limit.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/settings/tray_settings.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/supervised/tray_supervised_user.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_caps_lock.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_display.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/chromeos/tray_tracing.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_default_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/date/date_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/ime/tray_ime_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/overview/overview_button_tray.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/status_area_widget.cc View 2 chunks +1 line, -1 line 0 comments Download
D ash/system/tray/default_system_tray_delegate.h View 1 chunk +0 lines, -49 lines 0 comments Download
D ash/system/tray/default_system_tray_delegate.cc View 1 chunk +0 lines, -93 lines 0 comments Download
M ash/system/tray/system_tray.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/system/tray/system_tray_bubble.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/tray/system_tray_delegate.h View 1 chunk +0 lines, -342 lines 0 comments Download
D ash/system/tray/system_tray_delegate.cc View 1 chunk +0 lines, -288 lines 0 comments Download
M ash/system/tray/system_tray_item.cc View 1 chunk +1 line, -2 lines 0 comments Download
M ash/system/tray/system_tray_notifier.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_accessibility.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_update.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/tray_update.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/tray_user.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/system/user/update_observer.h View 1 chunk +0 lines, -23 lines 0 comments Download
M ash/system/user/user_card_view.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/system/user/user_view.cc View 2 chunks +1 line, -1 line 0 comments Download
M ash/sysui/shell_delegate_mus.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/status_area_widget_test_helper.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_system_tray_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/test_volume_control_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
M ash/test/tray_cast_test_api.cc View 1 chunk +1 line, -1 line 0 comments Download
D ash/volume_control_delegate.h View 1 chunk +0 lines, -26 lines 0 comments Download
M ash/wm/maximize_mode/maximize_mode_controller_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/overview/window_selector_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M ash/wm/system_gesture_event_filter_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/first_run/drive_first_run_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/merge_session_load_page.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/power/power_button_observer.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/profiles/avatar_menu_actions_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/launcher/chrome_launcher_controller.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/network_connect_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/networking_config_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_chromeos.cc View 2 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/ash/system_tray_delegate_utils.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/system_tray_tray_cast_browsertest_media_router_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/volume_controller_chromeos.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/ash/vpn_delegate_chromeos.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/webui/chromeos/emulator/device_emulator_message_handler.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (7 generated)
James Cook
msw, please take a look. (I'm going to start sending some of the reviews for ...
4 years, 6 months ago (2016-06-09 18:30:34 UTC) #2
msw
lgtm, hopefully most of the updated includes are actually needed (I only did spot IWYU ...
4 years, 6 months ago (2016-06-09 18:57:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056823002/1
4 years, 6 months ago (2016-06-09 19:14:18 UTC) #5
James Cook
On 2016/06/09 18:57:37, msw wrote: > lgtm, hopefully most of the updated includes are actually ...
4 years, 6 months ago (2016-06-09 19:14:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/198250)
4 years, 6 months ago (2016-06-09 19:23:51 UTC) #8
James Cook
On 2016/06/09 19:23:51, commit-bot: I haz the power wrote: > Try jobs failed on following ...
4 years, 6 months ago (2016-06-09 19:26:10 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056823002/1
4 years, 6 months ago (2016-06-09 19:26:56 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 20:10:19 UTC) #14
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 20:10:24 UTC) #15
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 20:12:44 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2a4d1ebf2a3b0c662cabc6e21c16b5f85eb86fe7
Cr-Commit-Position: refs/heads/master@{#398990}

Powered by Google App Engine
This is Rietveld 408576698