Fix incorrect new-space allocations in the parser during background compilation

Fix incorrect new-space allocations in the parser during background compilation

Thess place were forgotten when changing all allocations in the background
compiler to old-space. New-space allocation is not allowed in the background
compiler thread.

I added assert to places that should only be reachable during unoptimized compilation.

BUG=#26669
R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/82fac9b30bacf5ac7a8dcd523d6349d6a710ac51

[Florian Schneider, 2016-06-09 20:21:07]

Description was changed from

==========
Fix an incorrect new-space allocation in the background compilation

This place was forgotten when changing all allocations in the background
compiler to old-space. New-space allocation is not allowed in the background
compiler thread.

BUG=#26669
==========

to

==========
Fix incorrect new-space allocations in the parser during background compilation

This place was forgotten when changing all allocations in the background
compiler to old-space. New-space allocation is not allowed in the background
compiler thread.

BUG=#26669
==========

[Florian Schneider, 2016-06-09 20:21:52]

Description was changed from

==========
Fix incorrect new-space allocations in the parser during background compilation

This place was forgotten when changing all allocations in the background
compiler to old-space. New-space allocation is not allowed in the background
compiler thread.

BUG=#26669
==========

to

==========
Fix incorrect new-space allocations in the parser during background compilation

Thess place were forgotten when changing all allocations in the background
compiler to old-space. New-space allocation is not allowed in the background
compiler thread.

I added assert to places that should only be reachable during unoptimized
compilation.

BUG=#26669
==========

[Florian Schneider, 2016-06-09 20:22:18]

fschneider@google.com changed reviewers:
+ asiva@google.com

[siva, 2016-06-09 20:51:41]

lgtm

https://codereview.chromium.org/2056813002/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (right):

https://codereview.chromium.org/2056813002/diff/20001/runtime/vm/parser.cc#ne...
runtime/vm/parser.cc:11703: type_class, TypeArguments::Handle(Z), primary_pos,
Heap::kOld));
Type::New by default allocates in the kOld, but this is fine makes it more
explicit when reading the code.

[Florian Schneider, 2016-06-09 20:53:45]

Description was changed from

==========
Fix incorrect new-space allocations in the parser during background compilation

Thess place were forgotten when changing all allocations in the background
compiler to old-space. New-space allocation is not allowed in the background
compiler thread.

I added assert to places that should only be reachable during unoptimized
compilation.

BUG=#26669
==========

to

==========
Fix incorrect new-space allocations in the parser during background compilation

Thess place were forgotten when changing all allocations in the background
compiler to old-space. New-space allocation is not allowed in the background
compiler thread.

I added assert to places that should only be reachable during unoptimized
compilation.

BUG=#26669
R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/82fac9b30bacf5ac7a8dcd523d6349d6a710ac51
==========

[Florian Schneider, 2016-06-09 20:53:46]

Committed patchset #2 (id:20001) manually as
82fac9b30bacf5ac7a8dcd523d6349d6a710ac51 (presubmit successful).