Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 2056783002: Re-enable DexLoaderTests (Closed)

Created:
4 years, 6 months ago by pkotwicz
Modified:
4 years, 6 months ago
Reviewers:
Xi Han
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable DexLoaderTests https://codereview.chromium.org/2045313002/ fixed the bug with dx --incremental causing the DexLoaderTests to fail on partial rebuilds of chrome_public_test_apk BUG=617935 Committed: https://crrev.com/ab92c217cd5792ea92b9e52d2dc65d03992b6f68 Cr-Commit-Position: refs/heads/master@{#399023}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -9 lines) Patch
M chrome/android/webapk/shell_apk/javatests/src/org/chromium/webapk/shell_apk/DexLoaderTest.java View 5 chunks +5 lines, -9 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
pkotwicz
Xi can you please take a look?
4 years, 6 months ago (2016-06-09 17:58:43 UTC) #3
Xi Han
LGTM!
4 years, 6 months ago (2016-06-09 18:15:04 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056783002/1
4 years, 6 months ago (2016-06-09 18:46:59 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 21:34:24 UTC) #8
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-09 21:34:41 UTC) #9
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/ab92c217cd5792ea92b9e52d2dc65d03992b6f68 Cr-Commit-Position: refs/heads/master@{#399023}
4 years, 6 months ago (2016-06-09 21:36:15 UTC) #11
boliu
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/2057953002/ by boliu@chromium.org. ...
4 years, 6 months ago (2016-06-10 03:18:01 UTC) #12
boliu
4 years, 6 months ago (2016-06-10 03:23:21 UTC) #13
Message was sent while issue was closed.
On 2016/06/10 03:18:01, boliu wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/2057953002/ by mailto:boliu@chromium.org.
> 
> The reason for reverting is: Still red on the debug bot :(
> 
>
https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20%28dbg....

Looks like it failed on that bot *only*. Everything on chromium.android is still
green unlike last time

So that bot is kitkat debug. Not sure what's different about it..

Powered by Google App Engine
This is Rietveld 408576698