Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(560)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2056763003: EDK: Change Awakable::Awake()'s context, etc., to be a uint64_t. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

EDK: Change Awakable::Awake()'s context, etc., to be a uint64_t. This is in preparation for implementing the wait set API that was added in 91a7a240f900. R=azani@chromium.org B=#350 Committed: https://chromium.googlesource.com/external/mojo/+/b8f277aa8bd5810bac0cbadf0c5f0648336db2bc

Patch Set 1 #

Patch Set 2 : doh #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -110 lines) Patch
M mojo/edk/system/async_waiter.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/async_waiter.cc View 1 chunk +3 lines, -5 lines 0 comments Download
M mojo/edk/system/awakable.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/awakable_list.h View 1 chunk +3 lines, -3 lines 0 comments Download
M mojo/edk/system/awakable_list.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/awakable_list_unittest.cc View 1 6 chunks +9 lines, -9 lines 0 comments Download
M mojo/edk/system/core.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/core.cc View 5 chunks +9 lines, -6 lines 0 comments Download
M mojo/edk/system/core_test_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_consumer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_impl_unittest.cc View 9 chunks +9 lines, -9 lines 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/data_pipe_producer_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/dispatcher.h View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/dispatcher.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/local_message_pipe_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_dispatcher_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M mojo/edk/system/message_pipe_endpoint.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_endpoint.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/message_pipe_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/remote_data_pipe_impl_unittest.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M mojo/edk/system/remote_message_pipe_unittest.cc View 10 chunks +10 lines, -10 lines 0 comments Download
M mojo/edk/system/simple_dispatcher.h View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/simple_dispatcher.cc View 1 chunk +1 line, -1 line 0 comments Download
M mojo/edk/system/simple_dispatcher_unittest.cc View 5 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/waiter.h View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/edk/system/waiter.cc View 4 chunks +6 lines, -7 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.h View 4 chunks +6 lines, -6 lines 0 comments Download
M mojo/edk/system/waiter_test_utils.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M mojo/edk/system/waiter_unittest.cc View 7 chunks +8 lines, -8 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-09 18:07:20 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-06-10 14:46:32 UTC) #2
viettrungluu
ping again
4 years, 6 months ago (2016-06-10 18:58:25 UTC) #3
azani
lgtm
4 years, 6 months ago (2016-06-10 19:17:10 UTC) #4
viettrungluu
4 years, 6 months ago (2016-06-10 19:35:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
b8f277aa8bd5810bac0cbadf0c5f0648336db2bc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698