Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(163)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2056753002: [Sync] Attempt to fix a flake in OpenTabsTest. (Closed)

Created:
4 years, 6 months ago by maxbogue
Modified:
4 years, 6 months ago
Reviewers:
pavely
CC:
chromium-reviews, sync-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Sync] Attempt to fix a flake in OpenTabsTest. BUG=618741 Committed: https://crrev.com/32a5e3038a2b592133ef7dc19a10cc53e093b66f Cr-Commit-Position: refs/heads/master@{#399031}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add failure reason. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -4 lines) Patch
M chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java View 1 1 chunk +8 lines, -4 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
maxbogue
Pavel, PTAL!
4 years, 6 months ago (2016-06-09 18:44:43 UTC) #2
pavely
lgtm https://codereview.chromium.org/2056753002/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java File chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java (right): https://codereview.chromium.org/2056753002/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java#newcode267 chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java:267: pollInstrumentationThread(new Criteria() { optional: you can provide failure ...
4 years, 6 months ago (2016-06-09 19:03:27 UTC) #3
maxbogue
https://codereview.chromium.org/2056753002/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java File chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java (right): https://codereview.chromium.org/2056753002/diff/1/chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java#newcode267 chrome/android/sync_shell/javatests/src/org/chromium/chrome/browser/sync/OpenTabsTest.java:267: pollInstrumentationThread(new Criteria() { On 2016/06/09 19:03:27, pavely wrote: > ...
4 years, 6 months ago (2016-06-09 20:57:21 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056753002/20001
4 years, 6 months ago (2016-06-09 20:58:07 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 22:05:37 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 22:07:29 UTC) #10
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/32a5e3038a2b592133ef7dc19a10cc53e093b66f
Cr-Commit-Position: refs/heads/master@{#399031}

Powered by Google App Engine
This is Rietveld 408576698