Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Issue 2056703002: Remove dead code: mojom CheckerboardQuadState (Closed)

Created:
4 years, 6 months ago by Fady Samuel
Modified:
4 years, 6 months ago
Reviewers:
Tom Sepez, ajuma
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, cc-bugs_chromium.org, ben+mojo_chromium.org, darin (slow to review)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove dead code: mojom CheckerboardQuadState It doesn't look like CheckerboardQuadState is used anymore so this CL removes it. BUG=611802 TBR=tsepez@chromium.org CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel Committed: https://crrev.com/a28a58be2d6a0d5aa8e1cc19b97d9a9502ecc462 Cr-Commit-Position: refs/heads/master@{#398864}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -10 lines) Patch
M cc/ipc/quads.mojom View 2 chunks +0 lines, -10 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
Fady Samuel
+ajuma@ for cc OWNER +tsepez@ for ipc (I'm TBR'ing you since this is purely code ...
4 years, 6 months ago (2016-06-09 11:52:20 UTC) #3
Fady Samuel
PTAL Thanks!
4 years, 6 months ago (2016-06-09 11:52:41 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056703002/1
4 years, 6 months ago (2016-06-09 12:18:47 UTC) #7
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-09 13:09:50 UTC) #9
ajuma
lgtm
4 years, 6 months ago (2016-06-09 13:15:40 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056703002/1
4 years, 6 months ago (2016-06-09 13:42:39 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 13:46:46 UTC) #14
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 13:49:57 UTC) #16
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/a28a58be2d6a0d5aa8e1cc19b97d9a9502ecc462
Cr-Commit-Position: refs/heads/master@{#398864}

Powered by Google App Engine
This is Rietveld 408576698