Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(75)

Issue 2056693002: Replace std::trunc() with trunc() to support cross-compiling (Closed)

Created:
4 years, 6 months ago by asaka
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Replace std::trunc() with trunc() to support cross-compiling Fix-up of https://codereview.chromium.org/1965443003 required for certain toolchains that do not support std::trunc(). BUG= Committed: https://crrev.com/8c1b2623ccbedfcbfa4e78493dfaf2f554215a51 Cr-Commit-Position: refs/heads/master@{#36882}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M src/runtime/runtime-simd.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 20 (9 generated)
asaka
Hi @bbudge, @marja, This fix was needed to support one of our MIPS toolchains. Hoping ...
4 years, 6 months ago (2016-06-09 11:08:21 UTC) #3
asaka
4 years, 6 months ago (2016-06-09 11:09:00 UTC) #4
bbudge
lgtm
4 years, 6 months ago (2016-06-09 19:46:13 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056693002/1
4 years, 6 months ago (2016-06-10 06:04:50 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16922)
4 years, 6 months ago (2016-06-10 06:09:01 UTC) #9
asaka
can you help approve this as OWNER?
4 years, 6 months ago (2016-06-10 06:17:52 UTC) #11
asaka
On 2016/06/10 06:17:52, asaka wrote: > can you help approve this as OWNER? @machenbach^
4 years, 6 months ago (2016-06-10 06:18:25 UTC) #12
Michael Achenbach
lgtm (stamp) - I'm not a good owner either
4 years, 6 months ago (2016-06-10 07:35:54 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056693002/1
4 years, 6 months ago (2016-06-10 07:56:28 UTC) #16
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 07:59:10 UTC) #18
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 08:01:58 UTC) #20
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c1b2623ccbedfcbfa4e78493dfaf2f554215a51
Cr-Commit-Position: refs/heads/master@{#36882}

Powered by Google App Engine
This is Rietveld 408576698