|
|
DescriptionReplace std::trunc() with trunc() to support cross-compiling
Fix-up of https://codereview.chromium.org/1965443003 required for
certain toolchains that do not support std::trunc().
BUG=
Committed: https://crrev.com/8c1b2623ccbedfcbfa4e78493dfaf2f554215a51
Cr-Commit-Position: refs/heads/master@{#36882}
Patch Set 1 #
Messages
Total messages: 20 (9 generated)
Description was changed from ========== Replace std::trunc() with trunc() to support cross-compiling Fix-up of https://codereview.chromium.org/1965443003 required for certain toolchains that do not support std::trunc(). BUG= ========== to ========== Replace std::trunc() with trunc() to support cross-compiling Fix-up of https://codereview.chromium.org/1965443003 required for certain toolchains that do not support std::trunc(). BUG= ==========
asaka@opera.com changed reviewers: + bbudge@chromium.org, marja@chromium.org
Hi @bbudge, @marja, This fix was needed to support one of our MIPS toolchains. Hoping you will accept it! BR, Åsa
lgtm
The CQ bit was checked by asaka@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056693002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/16922)
asaka@opera.com changed reviewers: + machenbach@google.com
can you help approve this as OWNER?
On 2016/06/10 06:17:52, asaka wrote: > can you help approve this as OWNER? @machenbach^
machenbach@chromium.org changed reviewers: + ishell@chromium.org, machenbach@chromium.org, verwaest@chromium.org
lgtm (stamp) - I'm not a good owner either
The CQ bit was checked by asaka@opera.com
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056693002/1
Message was sent while issue was closed.
Description was changed from ========== Replace std::trunc() with trunc() to support cross-compiling Fix-up of https://codereview.chromium.org/1965443003 required for certain toolchains that do not support std::trunc(). BUG= ========== to ========== Replace std::trunc() with trunc() to support cross-compiling Fix-up of https://codereview.chromium.org/1965443003 required for certain toolchains that do not support std::trunc(). BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== Replace std::trunc() with trunc() to support cross-compiling Fix-up of https://codereview.chromium.org/1965443003 required for certain toolchains that do not support std::trunc(). BUG= ========== to ========== Replace std::trunc() with trunc() to support cross-compiling Fix-up of https://codereview.chromium.org/1965443003 required for certain toolchains that do not support std::trunc(). BUG= Committed: https://crrev.com/8c1b2623ccbedfcbfa4e78493dfaf2f554215a51 Cr-Commit-Position: refs/heads/master@{#36882} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/8c1b2623ccbedfcbfa4e78493dfaf2f554215a51 Cr-Commit-Position: refs/heads/master@{#36882} |