Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5)

Issue 2056673002: [mb] Switch staging bot to gyp for testing purposes (Closed)

Created:
4 years, 6 months ago by Michael Achenbach
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[mb] Switch staging bot to gyp for testing purposes This is to test the migration workflow. Will be reverted afterwards. BUG=chromium:616035 NOTRY=true TBR=vogelheim@chromium.org, jochen@chromium.org Committed: https://crrev.com/6a5d769be2b97a9ebca8ec58496cb20aed077f18 Cr-Commit-Position: refs/heads/master@{#36848}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M infra/mb/mb_config.pyl View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (5 generated)
Michael Achenbach
TBR
4 years, 6 months ago (2016-06-09 10:02:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056673002/1
4 years, 6 months ago (2016-06-09 10:02:40 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-09 10:04:45 UTC) #7
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/6a5d769be2b97a9ebca8ec58496cb20aed077f18 Cr-Commit-Position: refs/heads/master@{#36848}
4 years, 6 months ago (2016-06-09 10:06:21 UTC) #9
vogelheim
lgtm
4 years, 6 months ago (2016-06-09 13:15:28 UTC) #10
Michael Achenbach
4 years, 6 months ago (2016-06-09 13:19:12 UTC) #11
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2050243002/ by machenbach@chromium.org.

The reason for reverting is: Looks good. Switch back to gn..

Powered by Google App Engine
This is Rietveld 408576698