Fix glass extension on MD for Win 7 and below.

chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/frame/browser_desktop_window_tree_host_win.h"
 
 #include <dwmapi.h>
 
 #include "base/macros.h"
 #include "base/process/process_handle.h"
 #include "base/win/windows_version.h"
 #include "chrome/browser/lifetime/application_lifetime.h"
 #include "chrome/browser/themes/theme_service.h"
 #include "chrome/browser/themes/theme_service_factory.h"
 #include "chrome/browser/ui/views/frame/browser_frame.h"
 #include "chrome/browser/ui/views/frame/browser_view.h"
 #include "chrome/browser/ui/views/frame/browser_window_property_manager_win.h"
 #include "chrome/browser/ui/views/frame/system_menu_insertion_delegate_win.h"
 #include "chrome/browser/ui/views/tabs/tab_strip.h"
 #include "chrome/common/chrome_constants.h"
 #include "ui/base/material_design/material_design_controller.h"
 #include "ui/base/theme_provider.h"
 #include "ui/display/win/screen_win.h"
 #include "ui/gfx/geometry/point.h"
 #include "ui/views/controls/menu/native_menu_win.h"
-
-namespace {
-
-// The amount of additional non-client area to draw beyond what we have Windows
-// draw, in DIPs. Only used pre-Win 10.
-const int kDWMFrameBorderExtensionDips = 3;
-
-}  // namespace
+#include "ui/views/resources/grit/views_resources.h"
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserDesktopWindowTreeHostWin, public:
 
 BrowserDesktopWindowTreeHostWin::BrowserDesktopWindowTreeHostWin(
     views::internal::NativeWidgetDelegate* native_widget_delegate,
     views::DesktopNativeWidgetAura* desktop_native_widget_aura,
     BrowserView* browser_view,
     BrowserFrame* browser_frame)
     : DesktopWindowTreeHostWin(native_widget_delegate,
@@ skipping 46 matching lines @@
 
 bool BrowserDesktopWindowTreeHostWin::GetClientAreaInsets(
     gfx::Insets* insets) const {
   // Use the default client insets for an opaque frame or a glass popup/app
   // frame.
   if (!GetWidget()->ShouldUseNativeFrame() ||
       !browser_view_->IsBrowserTypeNormal()) {
     return false;
   }
 
-  int border_thickness = GetSystemMetrics(SM_CXSIZEFRAME);
   if (GetWidget()->IsFullscreen()) {
     // In fullscreen mode there is no frame.
-    border_thickness = 0;
-  } else if (!IsMaximized() &&
-             base::win::GetVersion() < base::win::VERSION_WIN10) {
-    // Reduce the Windows non-client border size because we extended the border
+    *insets = gfx::Insets();
+  } else {
+    const int frame_thickness = GetSystemMetrics(SM_CXSIZEFRAME);
+    // Reduce the Windows non-client border size because we extend the border
     // into our client area in UpdateDWMFrame().
-    border_thickness -= kDWMFrameBorderExtensionDips;
+    *insets = gfx::Insets(0, frame_thickness, frame_thickness,
+                          frame_thickness) - GetClientEdgeThicknesses();
   }
-  insets->Set(0, border_thickness, border_thickness, border_thickness);
   return true;
 }
 
 void BrowserDesktopWindowTreeHostWin::HandleCreate() {
   DesktopWindowTreeHostWin::HandleCreate();
   browser_window_property_manager_ =
       BrowserWindowPropertyManager::CreateBrowserWindowPropertyManager(
           browser_view_, GetHWND());
 }
 
@@ skipping 29 matching lines @@
       GetSystemMenu()->UpdateStates();
       return true;
   }
   return DesktopWindowTreeHostWin::PreHandleMSG(
       message, w_param, l_param, result);
 }
 
 void BrowserDesktopWindowTreeHostWin::PostHandleMSG(UINT message,
                                                     WPARAM w_param,
                                                     LPARAM l_param) {
+  HWND hwnd = GetHWND();
   switch (message) {
     case WM_CREATE:
-      minimize_button_metrics_.Init(GetHWND());
+      minimize_button_metrics_.Init(hwnd);
       break;
     case WM_WINDOWPOSCHANGED: {
       UpdateDWMFrame();
 
       // Windows lies to us about the position of the minimize button before a
       // window is visible.  We use this position to place the OTR avatar in RTL
       // mode, so when the window is shown, we need to re-layout and schedule a
       // paint for the non-client frame view so that the icon top has the
       // correct
       // position when the window becomes visible.  This fixes bugs where the
@@ skipping 12 matching lines @@
         GetWidget()->non_client_view()->SchedulePaint();
       }
       break;
     }
     case WM_ERASEBKGND: {
       gfx::Insets insets;
       if (!did_gdi_clear_ && GetClientAreaInsets(&insets)) {
         // This is necessary to avoid white flashing in the titlebar area around
         // the minimize/maximize/close buttons.
         DCHECK_EQ(0, insets.top());
-        HDC dc = GetDC(GetHWND());
+        HDC dc = GetDC(hwnd);
         MARGINS margins = GetDWMFrameMargins();
         RECT client_rect;
-        GetClientRect(GetHWND(), &client_rect);
+        GetClientRect(hwnd, &client_rect);
         HBRUSH brush = CreateSolidBrush(0);
         RECT rect = {0, 0, client_rect.right, margins.cyTopHeight};
         FillRect(dc, &rect, brush);
         DeleteObject(brush);
-        ReleaseDC(GetHWND(), dc);
+        ReleaseDC(hwnd, dc);
         did_gdi_clear_ = true;
       }
       break;
     }
   }
 }
 
 views::FrameMode BrowserDesktopWindowTreeHostWin::GetFrameMode() const {
   // We don't theme popup or app windows, so regardless of whether or not a
   // theme is active for normal browser windows, we don't want to use the custom
@@ skipping 47 matching lines @@
   // frame is currently native or opaque.
   if (!GetWidget()->client_view() || !browser_view_->IsBrowserTypeNormal() ||
       !DesktopWindowTreeHostWin::ShouldUseNativeFrame())
     return;
 
   MARGINS margins = GetDWMFrameMargins();
 
   DwmExtendFrameIntoClientArea(GetHWND(), &margins);
 }
 
+gfx::Insets
+BrowserDesktopWindowTreeHostWin::GetClientEdgeThicknesses() const {
+  // Maximized windows have no visible client edge; the content goes to
+  // the edge of the screen.  Restored windows on Windows 10 don't paint
+  // the full 3D client edge, but paint content right to the edge of the
+  // client area.
+  if (IsMaximized() ||
+      (base::win::GetVersion() >= base::win::VERSION_WIN10))
+    return gfx::Insets();
+
+  const ui::ThemeProvider* const tp = GetWidget()->GetThemeProvider();
+    return gfx::Insets(
+        0, tp->GetImageSkiaNamed(IDR_CONTENT_LEFT_SIDE)->width(),
+        tp->GetImageSkiaNamed(IDR_CONTENT_BOTTOM_CENTER)->height(),
+        tp->GetImageSkiaNamed(IDR_CONTENT_RIGHT_SIDE)->width());
+}
+
 MARGINS BrowserDesktopWindowTreeHostWin::GetDWMFrameMargins() const {
-  MARGINS margins = { 0 };
-
   // If we're using the opaque frame or we're fullscreen we don't extend the
   // glass in at all because it won't be visible.
   if (!GetWidget()->ShouldUseNativeFrame() || GetWidget()->IsFullscreen())
-    return margins;
+    return MARGINS{0};
 
-  if (!IsMaximized()) {
-    if (base::win::GetVersion() < base::win::VERSION_WIN10) {
-      gfx::Point dip_margin(kDWMFrameBorderExtensionDips,
-                            kDWMFrameBorderExtensionDips);
-      gfx::Point pixel_margin =
-          display::win::ScreenWin::DIPToScreenPoint(dip_margin);
-      margins.cxLeftWidth = pixel_margin.x();
-      margins.cxRightWidth = pixel_margin.x();
-      margins.cyBottomHeight = pixel_margin.y();
-
-      const bool md = ui::MaterialDesignController::IsModeMaterial();
-      if (!md) {
-        // Since the toolbar in non-md has rounded corners that show the glass
-        // frame behind, the extension of the glass area to the bottom of the
-        // tabstrip below isn't sufficient.  We need to go down further to the
-        // bottom of the rounded corner region.
-        margins.cyTopHeight = pixel_margin.y();
-      }
-    }
-    // Else, on Windows 10, we don't need extra border thickness because we draw
-    // right up to the edge of the client area and there are no rounded corners
-    // anywhere that we need to make sure are covered.
-  }
-
-  // Extend top for the tabstrip background.
+  // The glass should extend to the bottom of the tabstrip.
+  HWND hwnd = GetHWND();
   gfx::Rect tabstrip_bounds(
       browser_frame_->GetBoundsForTabStrip(browser_view_->tabstrip()));
   tabstrip_bounds =
-      display::win::ScreenWin::DIPToClientRect(GetHWND(), tabstrip_bounds);
-  margins.cyTopHeight += tabstrip_bounds.bottom();
+      display::win::ScreenWin::DIPToClientRect(hwnd, tabstrip_bounds);
 
-  return margins;
+  // Extend inwards far enough to go under the semitransparent client edges.
+  const gfx::Insets thicknesses = GetClientEdgeThicknesses();
+  gfx::Point left_top = display::win::ScreenWin::DIPToClientPoint(
+      hwnd, gfx::Point(thicknesses.left(), thicknesses.top()));
+  gfx::Point right_bottom = display::win::ScreenWin::DIPToClientPoint(
+      hwnd, gfx::Point(thicknesses.right(), thicknesses.bottom()));
+
+  if (base::win::GetVersion() <= base::win::VERSION_WIN7) {
+    // The 2 px (not DIP) at the inner edges of the glass are a light and
+    // dark line, so we must inset further to account for those.
+    constexpr gfx::Vector2d kDWMEdgeThickness(2, 2);
+    left_top += kDWMEdgeThickness;
+    right_bottom += kDWMEdgeThickness;
+  }
+
+  return MARGINS{left_top.x(), right_bottom.x(),
+                 tabstrip_bounds.bottom() + left_top.y(), right_bottom.y()};
 }
 
 ////////////////////////////////////////////////////////////////////////////////
 // BrowserDesktopWindowTreeHost, public:
 
 // static
 BrowserDesktopWindowTreeHost*
     BrowserDesktopWindowTreeHost::CreateBrowserDesktopWindowTreeHost(
         views::internal::NativeWidgetDelegate* native_widget_delegate,
         views::DesktopNativeWidgetAura* desktop_native_widget_aura,
         BrowserView* browser_view,
         BrowserFrame* browser_frame) {
   return new BrowserDesktopWindowTreeHostWin(native_widget_delegate,
                                              desktop_native_widget_aura,
                                              browser_view,
                                              browser_frame);
 }