Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/clang/value_cleanup/tests/list-value-append-original.cc

Issue 2056573002: value_cleanup: fixup ListValue::Append() calls that already have a unique_ptr to use. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: More tests Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/clang/value_cleanup/tests/list-value-append-expected.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/clang/value_cleanup/tests/list-value-append-original.cc
diff --git a/tools/clang/value_cleanup/tests/list-value-append-original.cc b/tools/clang/value_cleanup/tests/list-value-append-original.cc
index 02d74b937ca54adbb23dee71b163fae5fb73ba8a..988a288ac4020f02c8994d1da4be176339b46b9f 100644
--- a/tools/clang/value_cleanup/tests/list-value-append-original.cc
+++ b/tools/clang/value_cleanup/tests/list-value-append-original.cc
@@ -2,10 +2,20 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
+#include <memory>
+
#include "base/values.h"
#define true true
+std::unique_ptr<base::Value> ReturnsUniquePtr() {
+ return nullptr;
+}
+
+struct Thing {
+ std::unique_ptr<base::Value> ToValue() { return nullptr; }
+};
+
void F() {
base::ListValue list;
list.Append(new base::FundamentalValue(1 == 0));
@@ -13,4 +23,10 @@ void F() {
list.Append(new base::FundamentalValue(static_cast<unsigned char>(1.0)));
list.Append(new base::FundamentalValue(double{3}));
list.Append(new base::StringValue("abc"));
+
+ list.Append(ReturnsUniquePtr().release());
+ Thing thing;
+ list.Append(thing.ToValue().release());
+ std::unique_ptr<base::Value> unique_ptr_var;
+ list.Append(unique_ptr_var.release());
}
« no previous file with comments | « tools/clang/value_cleanup/tests/list-value-append-expected.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698