Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Unified Diff: mojo/android/system/base_run_loop.cc

Issue 2056563002: Roll base to 0032c8e1a72eb85d947d8df8de503caa62b4d0a8. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/android/javatests/validation_test_util.cc ('k') | mojo/android/system/core_impl.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/android/system/base_run_loop.cc
diff --git a/mojo/android/system/base_run_loop.cc b/mojo/android/system/base_run_loop.cc
index f361a94f98c2b1fc10bbba005d3834ef28a23f3a..5d49bfd653adafe1130b02e3b296846544b75df0 100644
--- a/mojo/android/system/base_run_loop.cc
+++ b/mojo/android/system/base_run_loop.cc
@@ -43,19 +43,26 @@ struct MessageLoopHolder {
} // namespace
-static jlong CreateBaseRunLoop(JNIEnv* env, jobject jcaller) {
+static jlong CreateBaseRunLoop(JNIEnv* env,
+ const JavaParamRef<jobject>& jcaller) {
return reinterpret_cast<uintptr_t>(new MessageLoopHolder());
}
-static void Run(JNIEnv* env, jobject jcaller, jlong runLoopID) {
+static void Run(JNIEnv* env,
+ const JavaParamRef<jobject>& jcaller,
+ jlong runLoopID) {
reinterpret_cast<MessageLoopHolder*>(runLoopID)->message_loop->Run();
}
-static void RunUntilIdle(JNIEnv* env, jobject jcaller, jlong runLoopID) {
+static void RunUntilIdle(JNIEnv* env,
+ const JavaParamRef<jobject>& jcaller,
+ jlong runLoopID) {
reinterpret_cast<MessageLoopHolder*>(runLoopID)->message_loop->RunUntilIdle();
}
-static void Quit(JNIEnv* env, jobject jcaller, jlong runLoopID) {
+static void Quit(JNIEnv* env,
+ const JavaParamRef<jobject>& jcaller,
+ jlong runLoopID) {
reinterpret_cast<MessageLoopHolder*>(runLoopID)->message_loop->Quit();
}
@@ -66,9 +73,9 @@ static void RunJavaRunnable(
}
static void PostDelayedTask(JNIEnv* env,
- jobject jcaller,
+ const JavaParamRef<jobject>& jcaller,
jlong runLoopID,
- jobject runnable,
+ const JavaParamRef<jobject>& runnable,
jlong delay) {
base::android::ScopedJavaGlobalRef<jobject> runnable_ref;
// ScopedJavaGlobalRef do not hold onto the env reference, so it is safe to
@@ -81,7 +88,9 @@ static void PostDelayedTask(JNIEnv* env,
base::TimeDelta::FromMicroseconds(delay));
}
-static void DeleteMessageLoop(JNIEnv* env, jobject jcaller, jlong runLoopID) {
+static void DeleteMessageLoop(JNIEnv* env,
+ const JavaParamRef<jobject>& jcaller,
+ jlong runLoopID) {
MessageLoopHolder* native_loop =
reinterpret_cast<MessageLoopHolder*>(runLoopID);
delete native_loop;
@@ -93,5 +102,3 @@ bool RegisterBaseRunLoop(JNIEnv* env) {
} // namespace android
} // namespace mojo
-
-
« no previous file with comments | « mojo/android/javatests/validation_test_util.cc ('k') | mojo/android/system/core_impl.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698