Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(680)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2056513002: Plumb MojoReplaceHandleWithReducedRights() out. (Closed)

Created:
4 years, 6 months ago by viettrungluu
Modified:
4 years, 6 months ago
Reviewers:
azani
CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, yzshen+mojopublicwatch_chromium.org
Base URL:
https://github.com/domokit/mojo.git@work790_replace_reduce_1
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Plumb MojoReplaceHandleWithReducedRights() out. Note: I didn't add tests in mojo/public/platform/native/system_impl_private_unittest.cc, since I plan to kill all of that soon anyway. (However, I added the corresponding plumbing, since otherwise tests under various NaCl configurations would fail to build.) R=azani@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/0271fce368b6130c7620a8ed29ee7f3c28f29bfa

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+255 lines, -52 lines) Patch
M mojo/edk/embedder/entrypoints.cc View 1 chunk +7 lines, -0 lines 0 comments Download
M mojo/edk/embedder/system_impl_private_entrypoints.cc View 1 chunk +11 lines, -0 lines 0 comments Download
M mojo/nacl/nonsfi/irt_mojo_nonsfi.cc View 1 chunk +1 line, -0 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings/mojo_irt.c View 24 chunks +39 lines, -23 lines 1 comment Download
M mojo/nacl/sfi/nacl_bindings/mojo_syscall.cc View 20 chunks +62 lines, -22 lines 0 comments Download
M mojo/nacl/sfi/nacl_bindings_generator/interface.py View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/c/system/tests/buffer_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/data_pipe_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/c/system/tests/handle_unittest.cc View 1 chunk +81 lines, -4 lines 0 comments Download
M mojo/public/c/system/tests/wait_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/public/platform/nacl/libmojo.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/public/platform/nacl/mojo_irt.h View 1 chunk +4 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private.h View 1 chunk +5 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.h View 2 chunks +6 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_impl_private_thunks.c View 1 chunk +10 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.h View 2 chunks +5 lines, -0 lines 0 comments Download
M mojo/public/platform/native/system_thunks.c View 1 chunk +9 lines, -0 lines 0 comments Download

Depends on Patchset:

Issue 2052553002 Patch 1

Messages

Total messages: 6 (1 generated)
viettrungluu
4 years, 6 months ago (2016-06-08 20:56:51 UTC) #1
viettrungluu
ping
4 years, 6 months ago (2016-06-09 16:58:54 UTC) #2
azani
lgtm https://codereview.chromium.org/2056513002/diff/1/mojo/nacl/sfi/nacl_bindings/mojo_irt.c File mojo/nacl/sfi/nacl_bindings/mojo_irt.c (right): https://codereview.chromium.org/2056513002/diff/1/mojo/nacl/sfi/nacl_bindings/mojo_irt.c#newcode94 mojo/nacl/sfi/nacl_bindings/mojo_irt.c:94: params[0] = 5; Maybe use an enum this ...
4 years, 6 months ago (2016-06-09 17:22:52 UTC) #3
viettrungluu
On 2016/06/09 17:22:52, azani wrote: > lgtm > > https://codereview.chromium.org/2056513002/diff/1/mojo/nacl/sfi/nacl_bindings/mojo_irt.c > File mojo/nacl/sfi/nacl_bindings/mojo_irt.c (right): > ...
4 years, 6 months ago (2016-06-09 17:24:27 UTC) #4
viettrungluu
4 years, 6 months ago (2016-06-09 17:24:47 UTC) #6
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
0271fce368b6130c7620a8ed29ee7f3c28f29bfa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698