Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Issue 2056503003: [turbofan] Add comments to CodeAssembler (Closed)

Created:
4 years, 6 months ago by danno
Modified:
4 years, 6 months ago
CC:
v8-reviews_googlegroups.com, v8-mips-ports_googlegroups.com, v8-x87-ports_googlegroups.com, v8-ppc-ports_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Add comments to CodeAssembler Committed: https://crrev.com/40b5c1d41f7da58411d5538f26cc736d2f40abe0 Cr-Commit-Position: refs/heads/master@{#36842}

Patch Set 1 #

Patch Set 2 : Format #

Patch Set 3 : Remove extraneous change #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -4 lines) Patch
M src/code-stub-assembler.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/arm/code-generator-arm.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/arm64/code-generator-arm64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/code-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/code-assembler.cc View 1 2 chunks +20 lines, -0 lines 0 comments Download
M src/compiler/ia32/code-generator-ia32.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/instruction-codes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-scheduler.cc View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/instruction-selector.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compiler/instruction-selector.cc View 2 chunks +11 lines, -2 lines 0 comments Download
M src/compiler/instruction-selector-impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/machine-operator.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M src/compiler/machine-operator.cc View 3 chunks +11 lines, -1 line 0 comments Download
M src/compiler/mips/code-generator-mips.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 1 chunk +5 lines, -0 lines 0 comments Download
M src/compiler/opcodes.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/raw-machine-assembler.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/typer.cc View 1 chunk +2 lines, -0 lines 0 comments Download
M src/compiler/verifier.cc View 1 chunk +4 lines, -0 lines 0 comments Download
M src/compiler/x64/code-generator-x64.cc View 1 chunk +5 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
danno
PTAL
4 years, 6 months ago (2016-06-09 06:45:01 UTC) #2
Benedikt Meurer
4 years, 6 months ago (2016-06-09 06:49:58 UTC) #4
Jarin
lgtm. It is unfortunate we need so much boilerplate for such a simple thing.
4 years, 6 months ago (2016-06-09 07:02:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056503003/40001
4 years, 6 months ago (2016-06-09 07:23:55 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 6 months ago (2016-06-09 07:25:59 UTC) #8
commit-bot: I haz the power
4 years, 6 months ago (2016-06-09 07:28:29 UTC) #10
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/40b5c1d41f7da58411d5538f26cc736d2f40abe0
Cr-Commit-Position: refs/heads/master@{#36842}

Powered by Google App Engine
This is Rietveld 408576698