Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2056503002:
Snap content to the top level window on chromeos (Closed)
|
Created:
4 years, 6 months ago by oshima Modified:
4 years, 6 months ago CC:
chromium-reviews, yusukes+watch_chromium.org, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, kalyank, piman+watch_chromium.org, danakj+watch_chromium.org, James Su Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionSnap content to the top level window on chromeos
BUG=618426
TEST=manual
Committed: https://crrev.com/894e134acd22e115b55fe0b309dcb2dcf5786974
Cr-Commit-Position: refs/heads/master@{#398774}
Patch Set 1 : #
Total comments: 1
Messages
Total messages: 17 (9 generated)
Patchset #1 (id:1) has been deleted
Description was changed from ========== Snap content to the top level window on chromeos BUG=618426 ========== to ========== Snap content to the top level window on chromeos BUG=618426 TEST=manual ==========
oshima@chromium.org changed reviewers: + scottmg@chromium.org
I have an idea to make this more easy to handle by setting "snapped" property to window. This is a simple fix so that we can merge it to 52.
On 2016/06/08 20:14:00, oshima wrote: > I have an idea to make this more easy to handle by setting "snapped" property to > window. This is a simple fix so that we can merge it to 52. Sorry about that (the screen type != ALTERNATE was confusing all over in that CL), thanks for fixing. lgtm
oshima@chromium.org changed reviewers: + sadrul@chromium.org
sadrul -> owners
Patchset #2 (id:40001) has been deleted
Patchset #2 (id:60001) has been deleted
lgtm Any chance this could have a test? https://codereview.chromium.org/2056503002/diff/20001/content/browser/rendere... File content/browser/renderer_host/render_widget_host_view_aura.cc (right): https://codereview.chromium.org/2056503002/diff/20001/content/browser/rendere... content/browser/renderer_host/render_widget_host_view_aura.cc:2595: #endif It may be OK to use GetToplevelWindow() on non-chromeos platforms too.
On 2016/06/09 02:57:04, sadrul wrote: > lgtm > > Any chance this could have a test? I'll create an utility that can be tested and switch to use it. > > https://codereview.chromium.org/2056503002/diff/20001/content/browser/rendere... > File content/browser/renderer_host/render_widget_host_view_aura.cc (right): > > https://codereview.chromium.org/2056503002/diff/20001/content/browser/rendere... > content/browser/renderer_host/render_widget_host_view_aura.cc:2595: #endif > It may be OK to use GetToplevelWindow() on non-chromeos platforms too. It may, but since I need to merge this to 52 (and this will change with aforementioned utility), I'd like to keep it.
The CQ bit was checked by oshima@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056503002/20001
Message was sent while issue was closed.
Description was changed from ========== Snap content to the top level window on chromeos BUG=618426 TEST=manual ========== to ========== Snap content to the top level window on chromeos BUG=618426 TEST=manual ==========
Message was sent while issue was closed.
Committed patchset #1 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Snap content to the top level window on chromeos BUG=618426 TEST=manual ========== to ========== Snap content to the top level window on chromeos BUG=618426 TEST=manual Committed: https://crrev.com/894e134acd22e115b55fe0b309dcb2dcf5786974 Cr-Commit-Position: refs/heads/master@{#398774} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/894e134acd22e115b55fe0b309dcb2dcf5786974 Cr-Commit-Position: refs/heads/master@{#398774} |
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
