Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(735)

Issue 2056493002: clang-tidy WaitableEvent refactor (ChromeOS side) (Closed)

Created:
4 years, 6 months ago by gab
Modified:
4 years, 6 months ago
Reviewers:
danakj
CC:
chromium-reviews, extensions-reviews_chromium.org, hashimoto+watch_chromium.org, dzhioev+watch_chromium.org, achuith+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, davemoore+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

clang-tidy WaitableEvent refactor (ChromeOS side) BUG=612843 TBR=danakj@chromium.org (purely mechanical and automated C++ change doesn't warrant another round of components OWNER IMO) Committed: https://crrev.com/3a2088cc4d83578a6465125207d505728f4c3899 Cr-Commit-Position: refs/heads/master@{#398664}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M chrome/browser/chromeos/extensions/default_app_order.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/chromeos/login/signin/oauth2_browsertest.cc View 2 chunks +7 lines, -5 lines 0 comments Download
M chromeos/dbus/blocking_method_caller.cc View 1 chunk +3 lines, -3 lines 0 comments Download
M chromeos/system/statistics_provider.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/exo/wayland/server_unittest.cc View 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 11 (4 generated)
gab
Self-review automated changes lgtm, TBR danakj for this automated/mechanical change.
4 years, 6 months ago (2016-06-08 19:57:58 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056493002/1
4 years, 6 months ago (2016-06-08 19:58:32 UTC) #3
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/200441)
4 years, 6 months ago (2016-06-08 20:12:07 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056493002/1
4 years, 6 months ago (2016-06-08 20:19:03 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-08 20:43:13 UTC) #8
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/3a2088cc4d83578a6465125207d505728f4c3899 Cr-Commit-Position: refs/heads/master@{#398664}
4 years, 6 months ago (2016-06-08 20:44:34 UTC) #10
danakj
4 years, 6 months ago (2016-06-09 20:34:46 UTC) #11
Message was sent while issue was closed.
LGTM

Powered by Google App Engine
This is Rietveld 408576698