third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js - Issue 2056433002: DevTools: properly format custom elements without nodenames

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

Issue 2056433002: DevTools: properly format custom elements without nodenames (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html ('K') | « third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

diff --git a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

index e15ab5e6d2c599086bae6c335f03a8d2b2f5162a..0e0c4f8d28065b05a5f348091ce7784c29cfe994 100644

--- a/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

+++ b/third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js

@@ -580,7 +580,12 @@ InjectedScript.prototype = {

return toString(obj);

if (subtype === "node") {

- var description = obj.nodeName.toLowerCase();

+ var description = "";

+ if (obj.nodeName)

+ description = obj.nodeName.toLowerCase();

+ else if (obj.constructor)

+ description = obj.constructor.name.toLowerCase();

switch (obj.nodeType) {

kozy 2016/06/08 20:58:05 What will return obj.nodeType in createCallback fo

luoe 2016/06/09 19:27:44 obj.nodeType will be undefined, in both cases when

case 1 /* Node.ELEMENT_NODE */:

description += obj.id ? "#" + obj.id : "";