DevTools: properly format custom elements without nodenames

DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.

BUG=616981
Committed: https://crrev.com/dd2fb8355246a4c73576c4784797bf9e9f249de9
Cr-Commit-Position: refs/heads/master@{#399066}

[luoe, 2016-06-08 20:40:34]

luoe@chromium.org changed reviewers:
+ kozyatinskiy@chromium.org

[luoe, 2016-06-08 20:41:38]

Description was changed from

==========
DevTools: properly format custom elements without nodenames

BUG=616981
==========

to

==========
DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.
BUG=616981
==========

[luoe, 2016-06-08 20:41:46]

Description was changed from

==========
DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.
BUG=616981
==========

to

==========
DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.

BUG=616981
==========

[kozy, 2016-06-08 20:58:05]

lgtm % nits

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html
(right):

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html:12:
Tests that logging custom elements uses proper formatting.
Usually we put test script in head tag before body.

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:589:
switch (obj.nodeType) {
What will return obj.nodeType in createCallback for custom element?

[luoe, 2016-06-09 19:27:44]

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTe...
File
third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html
(right):

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTe...
third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html:12:
Tests that logging custom elements uses proper formatting.
On 2016/06/08 20:58:04, kozyatinskiy wrote:
> Usually we put test script in head tag before body.

Done.

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js
(right):

https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js:589:
switch (obj.nodeType) {
On 2016/06/08 20:58:05, kozyatinskiy wrote:
> What will return obj.nodeType in createCallback for custom element?

obj.nodeType will be undefined, in both cases when the prototype does and does
not come from HTMLElement.

[kozy, 2016-06-09 20:32:05]

thanks! lgtm.

[luoe, 2016-06-09 20:33:21]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-09 20:33:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056433002/20001

[commit-bot: I haz the power, 2016-06-09 23:26:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-09 23:26:29]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[luoe, 2016-06-10 00:07:31]

The CQ bit was checked by luoe@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 00:08:27]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056433002/20001

[commit-bot: I haz the power, 2016-06-10 01:33:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 01:33:14]

Dry run: This issue passed the CQ dry run.

[luoe, 2016-06-10 01:33:35]

The CQ bit was checked by luoe@chromium.org

[commit-bot: I haz the power, 2016-06-10 01:34:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056433002/20001

[commit-bot: I haz the power, 2016-06-10 01:50:56]

Description was changed from

==========
DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.

BUG=616981
==========

to

==========
DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.

BUG=616981
==========

[commit-bot: I haz the power, 2016-06-10 01:50:57]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-06-10 01:52:44]

Description was changed from

==========
DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.

BUG=616981
==========

to

==========
DevTools: properly format custom elements without nodenames

Elements created via document.registerElement without using the
HTMLElement prototype will be formatted as nodes in the console.

BUG=616981

Committed: https://crrev.com/dd2fb8355246a4c73576c4784797bf9e9f249de9
Cr-Commit-Position: refs/heads/master@{#399066}
==========

[commit-bot: I haz the power, 2016-06-10 01:52:45]

Patchset 2 (id:??) landed as
https://crrev.com/dd2fb8355246a4c73576c4784797bf9e9f249de9
Cr-Commit-Position: refs/heads/master@{#399066}