Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(331)

Issue 2056433002: DevTools: properly format custom elements without nodenames (Closed)

Created:
4 years, 6 months ago by luoe
Modified:
4 years, 6 months ago
Reviewers:
kozy
CC:
chromium-reviews, caseq+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, blink-reviews, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

DevTools: properly format custom elements without nodenames Elements created via document.registerElement without using the HTMLElement prototype will be formatted as nodes in the console. BUG=616981 Committed: https://crrev.com/dd2fb8355246a4c73576c4784797bf9e9f249de9 Cr-Commit-Position: refs/heads/master@{#399066}

Patch Set 1 #

Total comments: 4

Patch Set 2 : Address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -1 line) Patch
A third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html View 1 1 chunk +57 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements-expected.txt View 1 1 chunk +7 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/platform/v8_inspector/InjectedScriptSource.js View 1 chunk +6 lines, -1 line 0 comments Download

Messages

Total messages: 21 (10 generated)
luoe
4 years, 6 months ago (2016-06-08 20:40:35 UTC) #2
kozy
lgtm % nits https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html File third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html (right): https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html#newcode12 third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html:12: Tests that logging custom elements uses ...
4 years, 6 months ago (2016-06-08 20:58:05 UTC) #5
luoe
https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html File third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html (right): https://codereview.chromium.org/2056433002/diff/1/third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html#newcode12 third_party/WebKit/LayoutTests/inspector/console/console-log-custom-elements.html:12: Tests that logging custom elements uses proper formatting. On ...
4 years, 6 months ago (2016-06-09 19:27:44 UTC) #6
kozy
thanks! lgtm.
4 years, 6 months ago (2016-06-09 20:32:05 UTC) #7
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056433002/20001
4 years, 6 months ago (2016-06-09 20:33:40 UTC) #9
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_ng/builds/236622)
4 years, 6 months ago (2016-06-09 23:26:29 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056433002/20001
4 years, 6 months ago (2016-06-10 00:08:27 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 6 months ago (2016-06-10 01:33:14 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056433002/20001
4 years, 6 months ago (2016-06-10 01:34:16 UTC) #17
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 01:50:57 UTC) #19
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 01:52:45 UTC) #21
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/dd2fb8355246a4c73576c4784797bf9e9f249de9
Cr-Commit-Position: refs/heads/master@{#399066}

Powered by Google App Engine
This is Rietveld 408576698