Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: gpu/command_buffer/service/gles2_cmd_decoder.cc

Issue 2056413003: Fix a bug in the implementation of DescheduleUntilFinishedCHROMIUM. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: compile error on windows. Created 4 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_mock.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gpu/command_buffer/service/gles2_cmd_decoder.cc
diff --git a/gpu/command_buffer/service/gles2_cmd_decoder.cc b/gpu/command_buffer/service/gles2_cmd_decoder.cc
index 39d2ea90669a56ce7e03d698cd9283bbc650f777..aa4bd7958f106d91e4a4bee562c134a5536c6964 100644
--- a/gpu/command_buffer/service/gles2_cmd_decoder.cc
+++ b/gpu/command_buffer/service/gles2_cmd_decoder.cc
@@ -623,6 +623,9 @@ class GLES2DecoderImpl : public GLES2Decoder, public ErrorStateClient {
bool HasMoreIdleWork() const override;
void PerformIdleWork() override;
+ bool HasPollingWork() const override;
+ void PerformPollingWork() override;
+
void WaitForReadPixels(base::Closure callback) override;
Logger* GetLogger() override;
@@ -14045,14 +14048,20 @@ void GLES2DecoderImpl::ProcessDescheduleUntilFinished() {
}
bool GLES2DecoderImpl::HasMoreIdleWork() const {
- return deschedule_until_finished_fence_ ||
- !pending_readpixel_fences_.empty() ||
+ return !pending_readpixel_fences_.empty() ||
gpu_tracer_->HasTracesToProcess();
}
void GLES2DecoderImpl::PerformIdleWork() {
gpu_tracer_->ProcessTraces();
ProcessPendingReadPixels(false);
+}
+
+bool GLES2DecoderImpl::HasPollingWork() const {
+ return !!deschedule_until_finished_fence_.get();
+}
+
+void GLES2DecoderImpl::PerformPollingWork() {
ProcessDescheduleUntilFinished();
}
« no previous file with comments | « gpu/command_buffer/service/gles2_cmd_decoder.h ('k') | gpu/command_buffer/service/gles2_cmd_decoder_mock.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698