Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Issue 2056383002: Upstream: Initialize ChromeWebApkHost in WebappLaunchActivity. (Closed)

Created:
4 years, 6 months ago by Xi Han
Modified:
4 years, 6 months ago
Reviewers:
pkotwicz, gone
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Upstream: Initialize ChromeWebApkHost in WebappLaunchActivity. This CL fixes a bug that when a WebAPK is launched without Chrome is running, WebApkValidator returns false for a valid WebAPK since the WebApkValidator hasn't been initialized. BUG=609122 Committed: https://crrev.com/53cac0649b0bcac6c135928287136050ad296dad Cr-Commit-Position: refs/heads/master@{#399544}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Nits. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -0 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/webapps/WebappLauncherActivity.java View 1 chunk +3 lines, -0 lines 0 comments Download
M chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (9 generated)
Xi Han
Hi Peter, could you please take a look? Thanks!
4 years, 6 months ago (2016-06-10 17:59:17 UTC) #5
pkotwicz
LGTM with nit This is probably the cause of what I observed in https://codereview.chromium.org/2049843004/ https://codereview.chromium.org/2056383002/diff/1/chrome/android/webapk/libs/client/src/org/chromium/webapk/lib/client/WebApkValidator.java ...
4 years, 6 months ago (2016-06-10 21:34:14 UTC) #6
Xi Han
This fixes exactly the issue that you mentioned in my previous CL. Since the changes ...
4 years, 6 months ago (2016-06-13 20:10:53 UTC) #7
Xi Han
Hi Dan, could you please take a look? Thanks!
4 years, 6 months ago (2016-06-13 20:11:21 UTC) #9
gone
lgtm
4 years, 6 months ago (2016-06-13 20:35:48 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056383002/20001
4 years, 6 months ago (2016-06-13 20:37:25 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-13 21:24:25 UTC) #15
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-13 21:24:53 UTC) #16
commit-bot: I haz the power
4 years, 6 months ago (2016-06-13 21:26:10 UTC) #18
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/53cac0649b0bcac6c135928287136050ad296dad
Cr-Commit-Position: refs/heads/master@{#399544}

Powered by Google App Engine
This is Rietveld 408576698