Add samples to Viewer.

Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004

Committed: https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
Committed: https://skia.googlesource.com/skia/+/c7027ab03f2e8bab4c74bc1b047642622d3d682b

[jvanverth1, 2016-06-10 20:48:08]

Description was changed from

==========
Add samples to Viewer.

BUG=skia:
==========

to

==========
Add samples to Viewer.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
==========

[jvanverth1, 2016-06-13 15:32:40]

Description was changed from

==========
Add samples to Viewer.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
==========

to

==========
Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
==========

[jvanverth1, 2016-06-13 15:36:43]

jvanverth@google.com changed reviewers:
+ bsalomon@google.com, egdaniel@google.com

[bsalomon, 2016-06-13 15:39:08]

lgtm

[jvanverth1, 2016-06-13 16:08:27]

The CQ bit was checked by jvanverth@google.com

[commit-bot: I haz the power, 2016-06-13 16:08:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056343004/40001

[commit-bot: I haz the power, 2016-06-13 16:14:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-13 16:14:07]

Try jobs failed on following builders:
  Build-Mac-Clang-x86_64-Release-Trybot on client.skia.compile (JOB_FAILED,
http://build.chromium.org/p/client.skia.compile/builders/Build-Mac-Clang-x86_...)

[jvanverth1, 2016-06-13 16:16:28]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-06-13 16:16:29]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com
Link to the patchset: https://codereview.chromium.org/2056343004/#ps60001
(title: "Fix Mac build")

[commit-bot: I haz the power, 2016-06-13 16:16:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056343004/60001

[commit-bot: I haz the power, 2016-06-13 16:31:30]

Description was changed from

==========
Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004
==========

to

==========
Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004

Committed:
https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
==========

[commit-bot: I haz the power, 2016-06-13 16:31:31]

Committed patchset #4 (id:60001) as
https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658

[egdaniel, 2016-06-13 18:28:51]

A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/2063883002/ by egdaniel@google.com.

The reason for reverting is: breaking on android compile.

[jvanverth1, 2016-06-13 20:38:41]

Description was changed from

==========
Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004

Committed:
https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
==========

to

==========
Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004

Committed:
https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
==========

[jvanverth1, 2016-06-15 17:09:37]

jvanverth@google.com changed reviewers:
+ djsollen@google.com, liyuqian@google.com

[jvanverth1, 2016-06-15 17:09:37]

Adding djsollen@ and liyuqian@. 

Updated to fix the Android build; please take a look.

[djsollen, 2016-06-15 17:17:58]

lgtm, and feel free to ignore my nits since I'm late to the party.

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp
File gyp/viewer.gyp (right):

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp#newcode39
gyp/viewer.gyp:39: # Samples
can you put these in their own gypi file that is shared by viewer and sampleApp?

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp#newcode198
gyp/viewer.gyp:198: 'views.gyp:views',
can you add a comment explaining why android need views but no one else does?

[jvanverth1, 2016-06-15 17:41:27]

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp
File gyp/viewer.gyp (right):

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp#newcode198
gyp/viewer.gyp:198: 'views.gyp:views',
On 2016/06/15 17:17:58, djsollen wrote:
> can you add a comment explaining why android need views but no one else does?

It's the other way around (others can use views.gyp but Android can't), but yes,
I can.

[liyuqian, 2016-06-15 19:01:29]

On 2016/06/15 17:41:27, jvanverth1 wrote:
> https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp
> File gyp/viewer.gyp (right):
> 
>
https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp#newcode198
> gyp/viewer.gyp:198: 'views.gyp:views',
> On 2016/06/15 17:17:58, djsollen wrote:
> > can you add a comment explaining why android need views but no one else
does?
> 
> It's the other way around (others can use views.gyp but Android can't), but
yes,
> I can.

looks good to me and runs good on my device

[jvanverth1, 2016-06-16 16:39:42]

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp
File gyp/viewer.gyp (right):

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp#newcode39
gyp/viewer.gyp:39: # Samples
On 2016/06/15 17:17:58, djsollen wrote:
> can you put these in their own gypi file that is shared by viewer and
sampleApp?

Done.

https://codereview.chromium.org/2056343004/diff/160001/gyp/viewer.gyp#newcode198
gyp/viewer.gyp:198: 'views.gyp:views',
On 2016/06/15 17:17:58, djsollen wrote:
> can you add a comment explaining why android need views but no one else does?

Done.

[jvanverth1, 2016-06-16 16:39:49]

The CQ bit was checked by jvanverth@google.com

[jvanverth1, 2016-06-16 16:39:49]

The patchset sent to the CQ was uploaded after l-g-t-m from bsalomon@google.com,
djsollen@google.com
Link to the patchset: https://codereview.chromium.org/2056343004/#ps200001
(title: "Add samples.gypi")

[commit-bot: I haz the power, 2016-06-16 16:39:59]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056343004/200001

[commit-bot: I haz the power, 2016-06-16 16:52:38]

Description was changed from

==========
Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004

Committed:
https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
==========

to

==========
Add samples to Viewer.

This adds support with animation, assuming the sample has
implemented onAnimate. Event handling has not been
implemented.

BUG=skia:
GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2056343004

Committed:
https://skia.googlesource.com/skia/+/76963e73704a42a18c29d6fbdcccb566e5c67658
Committed:
https://skia.googlesource.com/skia/+/c7027ab03f2e8bab4c74bc1b047642622d3d682b
==========

[commit-bot: I haz the power, 2016-06-16 16:52:39]

Committed patchset #11 (id:200001) as
https://skia.googlesource.com/skia/+/c7027ab03f2e8bab4c74bc1b047642622d3d682b