Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(160)

Issue 2056343002: Replace expected pixel result for video-layer-crash.html on Mac Retina. (Closed)

Created:
4 years, 6 months ago by jbroman
Modified:
4 years, 6 months ago
Reviewers:
ajuma
CC:
blink-reviews, chromium-reviews, feature-media-reviews_chromium.org, posciak+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace expected pixel result for video-layer-crash.html on Mac Retina. It looks like this was already flaky before my patch, but the rebaseline bot had the misfortune of grabbing a bad expectation. If so, hopefully committing the good expectation will fix things. BUG=618693 Committed: https://crrev.com/90e90026d8045a112853f0c9c26b119f5fbb964a Cr-Commit-Position: refs/heads/master@{#399213}

Patch Set 1 #

Patch Set 2 : text result #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -40 lines) Patch
M third_party/WebKit/LayoutTests/platform/mac-retina/media/video-layer-crash-expected.png View Binary file 0 comments Download
M third_party/WebKit/LayoutTests/platform/mac-retina/media/video-layer-crash-expected.txt View 1 1 chunk +24 lines, -40 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
jbroman
4 years, 6 months ago (2016-06-10 15:46:10 UTC) #2
ajuma
lgtm
4 years, 6 months ago (2016-06-10 15:47:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056343002/20001
4 years, 6 months ago (2016-06-10 15:53:33 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-10 16:59:47 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 16:59:49 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 17:02:42 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/90e90026d8045a112853f0c9c26b119f5fbb964a
Cr-Commit-Position: refs/heads/master@{#399213}

Powered by Google App Engine
This is Rietveld 408576698