Fix compatibility for gcl-try/git-try with repos not using tryserver.chromium

Fix compatibility for gcl-try/git-try with repos not using tryserver.chromium

BUG=334892
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=258174

[bradnelson, 2014-03-20 00:08:16]

lgtm

[Paweł Hajdan Jr., 2014-03-20 00:09:54]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-03-20 00:10:04]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/205633003/1

[commit-bot: I haz the power, 2014-03-20 00:11:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-03-20 00:11:38]

Presubmit check for 205633003-1 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Missing LGTM from an OWNER for these files:
    depot_tools/trychange.py

Presubmit checks took 89.8s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[smut, 2014-03-20 00:15:01]

https://codereview.chromium.org/205633003/diff/1/trychange.py
File trychange.py (right):

https://codereview.chromium.org/205633003/diff/1/trychange.py#newcode393
trychange.py:393: if not trybots and len(masters) == 1:
This is getting really hacky, and I hope this covers all cases. Could a
presubmit script ever return multiple masters, none of which are
tryserver.chromium?

https://codereview.chromium.org/205633003/diff/1/trychange.py#newcode394
trychange.py:394: trybots = masters[masters.keys()[0]]
There's also "trybots = masters.values()[0]", but it probably doesn't matter.

[Paweł Hajdan Jr., 2014-03-20 00:27:00]

https://codereview.chromium.org/205633003/diff/1/trychange.py
File trychange.py (right):

https://codereview.chromium.org/205633003/diff/1/trychange.py#newcode393
trychange.py:393: if not trybots and len(masters) == 1:
On 2014/03/20 00:15:02, smut wrote:
> This is getting really hacky, and I hope this covers all cases. Could a
> presubmit script ever return multiple masters, none of which are
> tryserver.chromium?

Yes.

https://codereview.chromium.org/205633003/diff/1/trychange.py#newcode394
trychange.py:394: trybots = masters[masters.keys()[0]]
On 2014/03/20 00:15:02, smut wrote:
> There's also "trybots = masters.values()[0]", but it probably doesn't matter.

Oh, indeed, thanks for suggestion.

[bradn, 2014-03-20 00:28:14]

lgtm

[Paweł Hajdan Jr., 2014-03-20 00:29:44]

The CQ bit was checked by phajdan.jr@chromium.org

[commit-bot: I haz the power, 2014-03-20 00:29:45]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/phajdan.jr@chromium.org/205633003/20001

[commit-bot: I haz the power, 2014-03-20 00:31:25]

Change committed as 258174