Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2056323002:
[tools/perf] Tear down state between webview_startup stories (Closed)
Description[tools/perf] Tear down state between webview_startup stories
This is needed for --page-repat and --pageset-repeat to work correctly.
BUG=613706
Committed: https://crrev.com/137ca695b63f964ff6788787e19db982754c5f73
Cr-Commit-Position: refs/heads/master@{#399435}
Patch Set 1 #
Messages
Total messages: 22 (11 generated)
Description was changed from ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 ========== to ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ==========
perezju@chromium.org changed reviewers: + alexandermont@chromium.org, zhenw@chromium.org
Good catch! Thanks! lgtm
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: winx64_10_perf_cq on tryserver.chromium.perf (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.chromium.perf/builders/winx64_10_perf_c...)
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056323002/1
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: win_chromium_rel_ng on tryserver.chromium.win (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
Description was changed from ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 CQ_EXTRA_TRYBOTS=tryserver.chromium.perf:android_s5_perf_cq;tryserver.chromium.perf:winx64_10_perf_cq;tryserver.chromium.perf:mac_retina_perf_cq ========== to ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 ==========
Removing extra trybots. This benchmark doesn't even run on windows.
The CQ bit was checked by perezju@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056323002/1
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 ========== to ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 ========== to ========== [tools/perf] Tear down state between webview_startup stories This is needed for --page-repat and --pageset-repeat to work correctly. BUG=613706 Committed: https://crrev.com/137ca695b63f964ff6788787e19db982754c5f73 Cr-Commit-Position: refs/heads/master@{#399435} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/137ca695b63f964ff6788787e19db982754c5f73 Cr-Commit-Position: refs/heads/master@{#399435}
Message was sent while issue was closed.
charliea@chromium.org changed reviewers: + charliea@chromium.org
Message was sent while issue was closed.
Thanks for catching this Juan! |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
