[merge-m52] Mac: Retain the child NSWindow in WidgetOwnerNSWindowAdapter before invoking close

[merge-m52] Mac: Retain the child NSWindow in WidgetOwnerNSWindowAdapter before invoking close

AppKit has gotten better at handling the last reference to an NSWindow
going away inside -[NSWindow close]. However, on 10.9, bad things can
happen if we don't retain the NSWindow being closed until after the
-[NSWindow close] call returns.

WidgetOwnerNSWindowAdapter::OnWindowWillClose() wasn't doing this. The
result: in some codepaths, a zombie access under the close call.

To fix, retain the window being closed.

BUG=616701
TEST=On OSX 10.9, have one browser tab, navigate to a page (e.g.
chrome://version), then press Backspace. The "Press Cmd+Left to go back"
bubble should appear. Wait for it to fade out completely. Then close the
tab via the tabstrip. Chrome shouldn't crash.

Review-Url: https://codereview.chromium.org/2056593002
Cr-Commit-Position: refs/heads/master@{#398890}
(cherry picked from commit 6777bcc56aff3a1dc27fb0adced9a462b22e4e33)

Committed: https://chromium.googlesource.com/chromium/src/+/f74417df0eb4a034004fa587c8835cf3ee69edac

[tapted, 2016-06-10 11:58:47]

Description was changed from

==========
[merge-m52] Mac: Retain the child NSWindow in WidgetOwnerNSWindowAdapter before
invoking close

AppKit has gotten better at handling the last reference to an NSWindow
going away inside -[NSWindow close]. However, on 10.9, bad things can
happen if we don't retain the NSWindow being closed until after the
-[NSWindow close] call returns.

WidgetOwnerNSWindowAdapter::OnWindowWillClose() wasn't doing this. The
result: in some codepaths, a zombie access under the close call.

To fix, retain the window being closed.

BUG=616701
TEST=On OSX 10.9, have one browser tab, navigate to a page (e.g.
chrome://version), then press Backspace. The "Press Cmd+Left to go back"
bubble should appear. Wait for it to fade out completely. Then close the
tab via the tabstrip. Chrome shouldn't crash.

Review-Url: https://codereview.chromium.org/2056593002
Cr-Commit-Position: refs/heads/master@{#398890}
(cherry picked from commit 6777bcc56aff3a1dc27fb0adced9a462b22e4e33)
==========

to

==========
[merge-m52] Mac: Retain the child NSWindow in WidgetOwnerNSWindowAdapter before
invoking close

AppKit has gotten better at handling the last reference to an NSWindow
going away inside -[NSWindow close]. However, on 10.9, bad things can
happen if we don't retain the NSWindow being closed until after the
-[NSWindow close] call returns.

WidgetOwnerNSWindowAdapter::OnWindowWillClose() wasn't doing this. The
result: in some codepaths, a zombie access under the close call.

To fix, retain the window being closed.

BUG=616701
TEST=On OSX 10.9, have one browser tab, navigate to a page (e.g.
chrome://version), then press Backspace. The "Press Cmd+Left to go back"
bubble should appear. Wait for it to fade out completely. Then close the
tab via the tabstrip. Chrome shouldn't crash.

Review-Url: https://codereview.chromium.org/2056593002
Cr-Commit-Position: refs/heads/master@{#398890}
(cherry picked from commit 6777bcc56aff3a1dc27fb0adced9a462b22e4e33)

Committed:
https://chromium.googlesource.com/chromium/src/+/f74417df0eb4a034004fa587c883...
==========

[tapted, 2016-06-10 11:58:51]

Committed patchset #1 (id:1) manually as
f74417df0eb4a034004fa587c8835cf3ee69edac.