Remove Isolate::cpu_profiler() usage in api.cc

Remove Isolate::cpu_profiler() usage in api.cc

Driveby: some surrounding code refactoring/cleanup.

BUG=v8:4789
Committed: https://crrev.com/231ae291d38ef5b9b75bc3b04073ffe87e8ef805
Cr-Commit-Position: refs/heads/master@{#36993}

[alph, 2016-06-10 21:35:01]

The CQ bit was checked by alph@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-06-10 21:35:07]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056253003/1

[commit-bot: I haz the power, 2016-06-10 22:02:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-06-10 22:02:48]

Dry run: This issue passed the CQ dry run.

[alph, 2016-06-10 22:10:40]

alph@chromium.org changed reviewers:
+ jochen@chromium.org, lpy@chromium.org, yangguo@chromium.org

[lpy, 2016-06-13 08:41:01]

lgtm from my side.

[Yang, 2016-06-14 13:04:17]

LGTM, but please wait for Jochen to reply.

https://codereview.chromium.org/2056253003/diff/1/src/profiler/cpu-profiler.h
File src/profiler/cpu-profiler.h (right):

https://codereview.chromium.org/2056253003/diff/1/src/profiler/cpu-profiler.h...
src/profiler/cpu-profiler.h:261: std::unique_ptr<CpuProfilesCollection>
profiles_;
We don't use unique_ptr in V8 until now. Is there any advantage over the current
code?

@Jochen: what's our policy on using std::unique_ptr?

[alph, 2016-06-14 15:47:15]

https://codereview.chromium.org/2056253003/diff/1/src/profiler/cpu-profiler.h
File src/profiler/cpu-profiler.h (right):

https://codereview.chromium.org/2056253003/diff/1/src/profiler/cpu-profiler.h...
src/profiler/cpu-profiler.h:261: std::unique_ptr<CpuProfilesCollection>
profiles_;
On 2016/06/14 13:04:16, Yang wrote:
> We don't use unique_ptr in V8 until now. Is there any advantage over the
current
> code?
> 
> @Jochen: what's our policy on using std::unique_ptr?

std::unique_ptr is allowed in Chromium C++ style guide
http://chromium-cpp.appspot.com v8 is using.
The advantage is that it naturally represents semantics of object ownership, and
it's safer from the leak avoidance point of view.

[Yang, 2016-06-15 09:24:33]

On 2016/06/14 15:47:15, alph_slow wrote:
> https://codereview.chromium.org/2056253003/diff/1/src/profiler/cpu-profiler.h
> File src/profiler/cpu-profiler.h (right):
> 
>
https://codereview.chromium.org/2056253003/diff/1/src/profiler/cpu-profiler.h...
> src/profiler/cpu-profiler.h:261: std::unique_ptr<CpuProfilesCollection>
> profiles_;
> On 2016/06/14 13:04:16, Yang wrote:
> > We don't use unique_ptr in V8 until now. Is there any advantage over the
> current
> > code?
> > 
> > @Jochen: what's our policy on using std::unique_ptr?
> 
> std::unique_ptr is allowed in Chromium C++ style guide
> http://chromium-cpp.appspot.com v8 is using.
> The advantage is that it naturally represents semantics of object ownership,
and
> it's safer from the leak avoidance point of view.

Thanks for the explanation. LGTM.

[alph, 2016-06-15 09:32:01]

The CQ bit was checked by alph@chromium.org

[commit-bot: I haz the power, 2016-06-15 09:32:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2056253003/1

[commit-bot: I haz the power, 2016-06-15 09:59:09]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-15 09:59:44]

Description was changed from

==========
Remove Isolate::cpu_profiler() usage in api.cc

Driveby: some surrounding code refactoring/cleanup.

BUG=v8:4789
==========

to

==========
Remove Isolate::cpu_profiler() usage in api.cc

Driveby: some surrounding code refactoring/cleanup.

BUG=v8:4789

Committed: https://crrev.com/231ae291d38ef5b9b75bc3b04073ffe87e8ef805
Cr-Commit-Position: refs/heads/master@{#36993}
==========

[commit-bot: I haz the power, 2016-06-15 09:59:45]

Patchset 1 (id:??) landed as
https://crrev.com/231ae291d38ef5b9b75bc3b04073ffe87e8ef805
Cr-Commit-Position: refs/heads/master@{#36993}