Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1071)

Issue 2056203002: Remove credentials from URL in printed page footer (Closed)

Created:
4 years, 6 months ago by battre
Modified:
4 years, 6 months ago
Reviewers:
Lei Zhang
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove credentials from URL in printed page footer BUG=618435 Committed: https://crrev.com/c9a049cbb44e89989b77be1fb3a31ff6346ff199 Cr-Commit-Position: refs/heads/master@{#399223}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -2 lines) Patch
M chrome/browser/ui/webui/print_preview/print_preview_handler.cc View 1 chunk +7 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
battre
Hi. Could you please review this CL? Thanks, Dominic
4 years, 6 months ago (2016-06-10 08:55:23 UTC) #2
Lei Zhang
lgtm
4 years, 6 months ago (2016-06-10 17:44:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2056203002/1
4 years, 6 months ago (2016-06-10 17:44:59 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 6 months ago (2016-06-10 17:48:58 UTC) #6
commit-bot: I haz the power
CQ bit was unchecked
4 years, 6 months ago (2016-06-10 17:49:10 UTC) #7
commit-bot: I haz the power
4 years, 6 months ago (2016-06-10 17:50:49 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/c9a049cbb44e89989b77be1fb3a31ff6346ff199
Cr-Commit-Position: refs/heads/master@{#399223}

Powered by Google App Engine
This is Rietveld 408576698