third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-reportonly-blocked.php - Issue 2056183002: Implement the `require-sri-for` CSP directive

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-reportonly-blocked.php

Issue 2056183002: Implement the `require-sri-for` CSP directive (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-reportonly-allowed.php ('k') | third_party/WebKit/LayoutTests/http/tests/security/contentSecurityPolicy/require-sri-for/require-sri-for-script-reportonly-blocked-expected.txt » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!-- <?php

	2 // TODO(mkwst) enable after windows hash differences are fixed

	3 header("Content-Security-Policy-Report-Only: require-sri-for script; script- src 'self' 'unsafe-inline'");

	4 ?> -->
	Mike West 2016/07/14 07:29:49 Drop the `<!--/-->`. Drop the `<!--/-->`.
	5 <!doctype html>

	6 <script src="/resources/testharness.js"></script>

	7 <script src="/resources/testharnessreport.js"></script>

	8 <script>

	9 // TODO(mkwst) remove .expected after windows hash differences are fixed

	10 async_test(t => {

	11 var watcher = new EventWatcher(t, document, ['securitypolicyviolation']) ;

	12 watcher

	13 .wait_for('securitypolicyviolation')

	14 .then(t.step_func_done(e => {

	15 assert_equals(e.blockedURI, "http://127.0.0.1:8000/security/cont entSecurityPolicy/require-sri-for/ran.js");

	16 }));

	17 }, "Script without integrity generates reports.");
	Mike West 2016/07/14 07:29:49 I don't think you'll have to change this, actually I don't think you'll have to change this, actually, as the `testharness.js` and `testharnessreport.js` bits are already processed and fired by the time you set up the listener. If you drop the comment above, you should get a passing test. Sergey Shekyan 2016/07/14 08:01:33 Indeed, there is almost nothing to change. `testha Show quoted text On 2016/07/14 07:29:49, Mike West wrote: > I don't think you'll have to change this, actually, as the `testharness.js` and > `testharnessreport.js` bits are already processed and fired by the time you set > up the listener. If you drop the comment above, you should get a passing test. Indeed, there is almost nothing to change. `testharnessreport.js` violation is catched by the EventWatcher though. I'll look tomorrow, if you think in can flaky.
	18

	19 var executed_test = async_test("Script that requires integrity executes and generates a violation report.");

	20 </script>

	21 <script src="ran.js"></script>

	22 <script>

	23 assert_equals(z, 13);

	24 executed_test.done();

	25 </script>

OLD	NEW