Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: components/page_load_metrics/renderer/page_timing_metrics_sender.cc

Issue 2056153002: Convert PageLoadMetrics to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/renderer/page_timing_metrics_sender.cc
diff --git a/components/page_load_metrics/renderer/page_timing_metrics_sender.cc b/components/page_load_metrics/renderer/page_timing_metrics_sender.cc
index 5572461683bd9a2898c7ba7ab595fee75d3f4e30..00e2da60ed7d8f7a96d713f5cac5d16881f012d0 100644
--- a/components/page_load_metrics/renderer/page_timing_metrics_sender.cc
+++ b/components/page_load_metrics/renderer/page_timing_metrics_sender.cc
@@ -9,8 +9,7 @@
#include "base/callback.h"
#include "base/time/time.h"
#include "base/timer/timer.h"
-#include "components/page_load_metrics/common/page_load_metrics_messages.h"
-#include "ipc/ipc_sender.h"
+#include "components/page_load_metrics/common/page_load_metrics_param_traits.h"
namespace page_load_metrics {
@@ -20,15 +19,14 @@ const int kTimerDelayMillis = 1000;
} // namespace
PageTimingMetricsSender::PageTimingMetricsSender(
- IPC::Sender* ipc_sender,
- int routing_id,
+ mojom::PageLoadMetrics* page_load_metrics,
std::unique_ptr<base::Timer> timer,
const PageLoadTiming& initial_timing)
- : ipc_sender_(ipc_sender),
- routing_id_(routing_id),
+ : page_load_metrics_(page_load_metrics),
timer_(std::move(timer)),
last_timing_(initial_timing),
metadata_(PageLoadMetadata()) {
+ DCHECK(page_load_metrics);
// Send an initial IPC relatively early to help track aborts.
EnsureSendTimer(kInitialTimerDelayMillis);
}
@@ -74,8 +72,7 @@ void PageTimingMetricsSender::EnsureSendTimer(int delay) {
}
void PageTimingMetricsSender::SendNow() {
- ipc_sender_->Send(new PageLoadMetricsMsg_TimingUpdated(
- routing_id_, last_timing_, metadata_));
+ page_load_metrics_->TimingUpdated(last_timing_, metadata_);
}
} // namespace page_load_metrics

Powered by Google App Engine
This is Rietveld 408576698