Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1532)

Unified Diff: components/page_load_metrics/renderer/fake_page_load_metrics.cc

Issue 2056153002: Convert PageLoadMetrics to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/page_load_metrics/renderer/fake_page_load_metrics.cc
diff --git a/components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc b/components/page_load_metrics/renderer/fake_page_load_metrics.cc
similarity index 56%
rename from components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc
rename to components/page_load_metrics/renderer/fake_page_load_metrics.cc
index e1e8e54ecdb436a12a287076c56327e9aa1a1b25..289de28291c96fa94186b29f3032c1d36e7bb6f6 100644
--- a/components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.cc
+++ b/components/page_load_metrics/renderer/fake_page_load_metrics.cc
@@ -2,27 +2,26 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
-#include "components/page_load_metrics/common/page_load_metrics_messages.h"
-#include "components/page_load_metrics/renderer/fake_page_timing_metrics_ipc_sender.h"
+#include "components/page_load_metrics/common/page_load_metrics_param_traits.h"
+#include "components/page_load_metrics/renderer/fake_page_load_metrics.h"
#include "ipc/ipc_message.h"
#include "ipc/ipc_message_macros.h"
#include "testing/gtest/include/gtest/gtest.h"
namespace page_load_metrics {
-FakePageTimingMetricsIPCSender::FakePageTimingMetricsIPCSender() {}
+FakePageLoadMetrics::FakePageLoadMetrics() {}
-FakePageTimingMetricsIPCSender::~FakePageTimingMetricsIPCSender() {
+FakePageLoadMetrics::~FakePageLoadMetrics() {
VerifyExpectedTimings();
}
-void FakePageTimingMetricsIPCSender::ExpectPageLoadTiming(
- const PageLoadTiming& timing) {
+void FakePageLoadMetrics::ExpectPageLoadTiming(const PageLoadTiming& timing) {
VerifyExpectedTimings();
expected_timings_.push_back(timing);
}
-void FakePageTimingMetricsIPCSender::VerifyExpectedTimings() const {
+void FakePageLoadMetrics::VerifyExpectedTimings() const {
// Ideally we'd just call ASSERT_EQ(actual_timings_, expected_timings_) here,
// but this causes the generated gtest code to fail to build on Windows. See
// the comments in the header file for additional details.
@@ -34,19 +33,8 @@ void FakePageTimingMetricsIPCSender::VerifyExpectedTimings() const {
}
}
-bool FakePageTimingMetricsIPCSender::Send(IPC::Message* message) {
- IPC_BEGIN_MESSAGE_MAP(FakePageTimingMetricsIPCSender, *message)
- IPC_MESSAGE_HANDLER(PageLoadMetricsMsg_TimingUpdated, OnTimingUpdated)
- IPC_MESSAGE_UNHANDLED(ADD_FAILURE())
- IPC_END_MESSAGE_MAP()
-
- delete message;
- return true;
-}
-
-void FakePageTimingMetricsIPCSender::OnTimingUpdated(
- const PageLoadTiming& timing,
- PageLoadMetadata metadata) {
+void FakePageLoadMetrics::TimingUpdated(const PageLoadTiming& timing,
+ const PageLoadMetadata& metadata) {
actual_timings_.push_back(timing);
VerifyExpectedTimings();
}

Powered by Google App Engine
This is Rietveld 408576698