components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc - Issue 2056153002: Convert PageLoadMetrics to Mojo

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

Issue 2056153002: Convert PageLoadMetrics to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix gyp build deps Created 4 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/page_load_metrics/browser/metrics_web_contents_observer.cc ('K') | « components/page_load_metrics/browser/metrics_web_contents_observer.cc ('k') | components/page_load_metrics/common/BUILD.gn » ('j') | components/page_load_metrics/common/page_load_metrics.typemap » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

diff --git a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

index 993a0f2fc4e22e297165acc10cb54e5945fec38f..609b8b03580ac9799585dcddf4750a2e71ef3d2e 100644

--- a/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

+++ b/components/page_load_metrics/browser/metrics_web_contents_observer_unittest.cc

@@ -115,10 +115,7 @@ class MetricsWebContentsObserverTest

void SimulateTimingUpdate(const PageLoadTiming& timing,

content::RenderFrameHost* render_frame_host) {

- ASSERT_TRUE(observer_->OnMessageReceived(

- PageLoadMetricsMsg_TimingUpdated(observer_->routing_id(), timing,

- PageLoadMetadata()),

- render_frame_host));

+ observer_->OnTimingUpdated(render_frame_host, timing, PageLoadMetadata());

}

void AttachObserver() {