Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(101)

Side by Side Diff: components/page_load_metrics/renderer/metrics_render_frame_observer.h

Issue 2056153002: Convert PageLoadMetrics to Mojo (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_ 5 #ifndef COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_
6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_ 6 #define COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_OBS ERVER_H_
7 7
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/macros.h" 10 #include "base/macros.h"
11 #include "components/page_load_metrics/common/page_load_metrics.mojom.h"
11 #include "components/page_load_metrics/common/page_load_timing.h" 12 #include "components/page_load_metrics/common/page_load_timing.h"
12 #include "content/public/renderer/render_frame_observer.h" 13 #include "content/public/renderer/render_frame_observer.h"
13 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h" 14 #include "third_party/WebKit/public/platform/WebLoadingBehaviorFlag.h"
14 15
15 namespace base { 16 namespace base {
16 class Timer; 17 class Timer;
17 } // namespace base 18 } // namespace base
18 19
19 namespace page_load_metrics { 20 namespace page_load_metrics {
20 21
21 class PageTimingMetricsSender; 22 class PageTimingMetricsSender;
22 23
23 // MetricsRenderFrameObserver observes RenderFrame notifications, and 24 // MetricsRenderFrameObserver observes RenderFrame notifications, and
24 // sends page load timing information to the browser process over IPC. 25 // sends page load timing information to the browser process over IPC.
25 class MetricsRenderFrameObserver : public content::RenderFrameObserver { 26 class MetricsRenderFrameObserver : public content::RenderFrameObserver {
26 public: 27 public:
27 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame); 28 explicit MetricsRenderFrameObserver(content::RenderFrame* render_frame);
29 // For testing only.
30 MetricsRenderFrameObserver(
31 content::RenderFrame* render_frame,
32 page_load_metrics::mojom::PageLoadMetricsPtr page_load_metrics);
28 ~MetricsRenderFrameObserver() override; 33 ~MetricsRenderFrameObserver() override;
29 34
30 // RenderFrameObserver implementation 35 // RenderFrameObserver implementation
31 void DidChangePerformanceTiming() override; 36 void DidChangePerformanceTiming() override;
32 void DidObserveLoadingBehavior( 37 void DidObserveLoadingBehavior(
33 blink::WebLoadingBehaviorFlag behavior) override; 38 blink::WebLoadingBehaviorFlag behavior) override;
34 void DidCommitProvisionalLoad(bool is_new_navigation, 39 void DidCommitProvisionalLoad(bool is_new_navigation,
35 bool is_same_page_navigation) override; 40 bool is_same_page_navigation) override;
36 void OnDestruct() override; 41 void OnDestruct() override;
37 42
38 private: 43 private:
44 // Must be destroyed after |page_timing_metrics_sender_|.
45 page_load_metrics::mojom::PageLoadMetricsPtr page_load_metrics_;
46
39 // Will be null when we're not actively sending metrics. 47 // Will be null when we're not actively sending metrics.
40 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_; 48 std::unique_ptr<PageTimingMetricsSender> page_timing_metrics_sender_;
41 49
42 void SendMetrics(); 50 void SendMetrics();
43 virtual bool ShouldSendMetrics() const; 51 virtual bool ShouldSendMetrics() const;
44 virtual PageLoadTiming GetTiming() const; 52 virtual PageLoadTiming GetTiming() const;
45 virtual std::unique_ptr<base::Timer> CreateTimer() const; 53 virtual std::unique_ptr<base::Timer> CreateTimer() const;
46 virtual bool HasNoRenderFrame() const; 54 virtual bool HasNoRenderFrame() const;
47 55
48 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver); 56 DISALLOW_COPY_AND_ASSIGN(MetricsRenderFrameObserver);
49 }; 57 };
50 58
51 } // namespace page_load_metrics 59 } // namespace page_load_metrics
52 60
53 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_ OBSERVER_H_ 61 #endif // COMPONENTS_PAGE_LOAD_METRICS_RENDERER_PAGE_LOAD_METRICS_RENDER_FRAME_ OBSERVER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698