Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 20561004: Linux: fix compatibility with nss-3.15 and <gcc-4.6 (Closed)

Created:
7 years, 5 months ago by Paweł Hajdan Jr.
Modified:
7 years, 5 months ago
Reviewers:
wtc
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Linux: fix compatibility with nss-3.15 and <gcc-4.6 It turns out that gcc older than 4.6 was failing the compile on typedef redefinition. See https://bugs.gentoo.org/show_bug.cgi?id=476832 for more info. I have verified this fix works with gcc-4.5. BUG=none R=wtc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=213953

Patch Set 1 #

Total comments: 2

Patch Set 2 : whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/third_party/nss/ssl/bodge/secitem_array.c View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
7 years, 5 months ago (2013-07-25 23:23:14 UTC) #1
wtc
Patch set 1 LGTM. https://codereview.chromium.org/20561004/diff/1/net/third_party/nss/ssl/bodge/secitem_array.c File net/third_party/nss/ssl/bodge/secitem_array.c (right): https://codereview.chromium.org/20561004/diff/1/net/third_party/nss/ssl/bodge/secitem_array.c#newcode19 net/third_party/nss/ssl/bodge/secitem_array.c:19: typedef struct SECItemArrayStr SECItemArray; Nit: ...
7 years, 5 months ago (2013-07-26 01:30:38 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/20561004/diff/1/net/third_party/nss/ssl/bodge/secitem_array.c File net/third_party/nss/ssl/bodge/secitem_array.c (right): https://codereview.chromium.org/20561004/diff/1/net/third_party/nss/ssl/bodge/secitem_array.c#newcode19 net/third_party/nss/ssl/bodge/secitem_array.c:19: typedef struct SECItemArrayStr SECItemArray; On 2013/07/26 01:30:38, wtc wrote: ...
7 years, 5 months ago (2013-07-26 18:08:23 UTC) #3
Paweł Hajdan Jr.
7 years, 5 months ago (2013-07-26 18:09:28 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r213953 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698