third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-async-setcert-with-gc.html - Issue 2056053003: Change MediaKeys.setServerCertificate() to return Promise<boolean>

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-async-setcert-with-gc.html

Issue 2056053003: Change MediaKeys.setServerCertificate() to return Promise<boolean> (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: resolve false Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « no previous file | third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html » ('j') | third_party/WebKit/LayoutTests/media/encrypted-media/encrypted-media-syntax.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <title>Test asynchronous setServerCertificate while running garbage coll ection</title>	4 <title>Test asynchronous setServerCertificate while running garbage coll ection</title>

5 <script src="encrypted-media-utils.js"></script>	5 <script src="encrypted-media-utils.js"></script>

6 <script src="../../resources/testharness.js"></script>	6 <script src="../../resources/testharness.js"></script>

7 <script src="../../resources/testharnessreport.js"></script>	7 <script src="../../resources/testharnessreport.js"></script>

8 </head>	8 </head>

9 <body>	9 <body>

10 <div id="log"></div>	10 <div id="log"></div>

11 <script>	11 <script>

12 // Run garbage collection continuously.	12 // Run garbage collection continuously.

13 setInterval(asyncGC, 0);	13 setInterval(asyncGC, 0);

14	14

15 promise_test(function(test)	15 promise_test(function(test)

16 {	16 {

17 return navigator.requestMediaKeySystemAccess('org.w3.clearkey', [{}]).then(function(access) {	17 return navigator.requestMediaKeySystemAccess('org.w3.clearkey', [{}]).then(function(access) {

18 return access.createMediaKeys();	18 return access.createMediaKeys();

19 }).then(function(mediaKeys) {	19 }).then(function(mediaKeys) {

20 var cert = new Uint8Array(200);	20 var cert = new Uint8Array(200);

21 return mediaKeys.setServerCertificate(cert);	21 return mediaKeys.setServerCertificate(cert);

22 }).then(function() {	22 }).then(function(result) {

23 assert_unreached('setServerCertificate() did not fail');	23 assert_false(result);

24 }, function(e) {

25 assert_equals(e.name, 'NotSupportedError');

26 return Promise.resolve();

27 });	24 });
	ddorwin 2016/06/13 17:28:09 Do we need something like this here to catch an in Do we need something like this here to catch an incorrect rejection? This appears to pass without a done() call in the expected path. .catch(function(error) { forceTestFailureFromPromise jrummell 2016/06/13 18:54:13 This is a promise_test(), so it fails if the promi Show quoted text On 2016/06/13 17:28:09, ddorwin wrote: > Do we need something like this here to catch an incorrect rejection? This > appears to pass without a done() call in the expected path. > .catch(function(error) { > forceTestFailureFromPromise This is a promise_test(), so it fails if the promise fails. The older tests use async_test(), where we need to fail the test if the promise is rejected.
28 }, 'Test asynchronous setServerCertificate while running garbage col lection.');	25 }, 'Test asynchronous setServerCertificate while running garbage col lection.');

29 </script>	26 </script>

30 </body>	27 </body>

31 </html>	28 </html>

OLD	NEW