Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2559)

Issue 2056053002: We did not set the pointer type for WebMouseEvent, which is created from NSEvent in WebMouseEventBu… (Closed)

Created:
4 years, 6 months ago by lanwei
Modified:
4 years, 6 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2743
Target Ref:
refs/pending/branch-heads/2743
Project:
chromium
Visibility:
Public.

Description

We did not set the pointer type for WebMouseEvent, which is created from NSEvent in WebMouseEventBuilder::Build. Now we set the pointer type based on the NSEvent's type to see if it is a tablet event or subtype of a mouse event to see its input device. Reference: https://developer.apple.com/library/mac/documentation/Cocoa/Conceptual/EventOverview/EventObjectsTypes/EventObjectsTypes.html#//apple_ref/doc/uid/10000060i-CH4-SW4 BUG=615122 Review-Url: https://codereview.chromium.org/2022843002 Cr-Commit-Position: refs/heads/master@{#398635} (cherry picked from commit 74a646d254f3836d7df802857b5a926adc4ec87b) Committed: https://chromium.googlesource.com/chromium/src/+/f069916c1f350baa4b7f6f2c6b3d9236aa1bdb94

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -1 line) Patch
M content/browser/renderer_host/input/web_input_event_builders_mac.mm View 2 chunks +21 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
lanwei
4 years, 6 months ago (2016-06-09 22:19:06 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
f069916c1f350baa4b7f6f2c6b3d9236aa1bdb94.

Powered by Google App Engine
This is Rietveld 408576698