Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(275)

Side by Side Diff: Source/core/xml/XMLHttpRequest.cpp

Issue 20560007: On request error, always fire events on the XMLHttpRequestUpload before the XMLHttpRequest (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/upload-request-error-event-order-expected.txt ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved. 2 * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org> 3 * Copyright (C) 2005-2007 Alexey Proskuryakov <ap@webkit.org>
4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org> 4 * Copyright (C) 2007, 2008 Julien Chaffraix <jchaffraix@webkit.org>
5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved. 5 * Copyright (C) 2008, 2011 Google Inc. All rights reserved.
6 * Copyright (C) 2012 Intel Corporation 6 * Copyright (C) 2012 Intel Corporation
7 * 7 *
8 * This library is free software; you can redistribute it and/or 8 * This library is free software; you can redistribute it and/or
9 * modify it under the terms of the GNU Lesser General Public 9 * modify it under the terms of the GNU Lesser General Public
10 * License as published by the Free Software Foundation; either 10 * License as published by the Free Software Foundation; either
(...skipping 838 matching lines...) Expand 10 before | Expand all | Expand 10 after
849 clearResponse(); 849 clearResponse();
850 clearRequest(); 850 clearRequest();
851 m_error = true; 851 m_error = true;
852 852
853 changeState(DONE); 853 changeState(DONE);
854 } 854 }
855 855
856 void XMLHttpRequest::networkError() 856 void XMLHttpRequest::networkError()
857 { 857 {
858 genericError(); 858 genericError();
859 m_progressEventThrottle.dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent: :create(eventNames().errorEvent));
860 if (!m_uploadComplete) { 859 if (!m_uploadComplete) {
861 m_uploadComplete = true; 860 m_uploadComplete = true;
862 if (m_upload && m_uploadEventsAllowed) 861 if (m_upload && m_uploadEventsAllowed)
863 m_upload->dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent::creat e(eventNames().errorEvent)); 862 m_upload->dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent::creat e(eventNames().errorEvent));
864 } 863 }
864 m_progressEventThrottle.dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent: :create(eventNames().errorEvent));
865 internalAbort(); 865 internalAbort();
866 } 866 }
867 867
868 void XMLHttpRequest::abortError() 868 void XMLHttpRequest::abortError()
869 { 869 {
870 genericError(); 870 genericError();
871 m_progressEventThrottle.dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent: :create(eventNames().abortEvent));
872 if (!m_uploadComplete) { 871 if (!m_uploadComplete) {
873 m_uploadComplete = true; 872 m_uploadComplete = true;
874 if (m_upload && m_uploadEventsAllowed) 873 if (m_upload && m_uploadEventsAllowed)
875 m_upload->dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent::creat e(eventNames().abortEvent)); 874 m_upload->dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent::creat e(eventNames().abortEvent));
876 } 875 }
876 m_progressEventThrottle.dispatchEventAndLoadEnd(XMLHttpRequestProgressEvent: :create(eventNames().abortEvent));
877 } 877 }
878 878
879 void XMLHttpRequest::dropProtectionSoon() 879 void XMLHttpRequest::dropProtectionSoon()
880 { 880 {
881 if (m_protectionTimer.isActive()) 881 if (m_protectionTimer.isActive())
882 return; 882 return;
883 m_protectionTimer.startOneShot(0); 883 m_protectionTimer.startOneShot(0);
884 } 884 }
885 885
886 void XMLHttpRequest::dropProtection(Timer<XMLHttpRequest>*) 886 void XMLHttpRequest::dropProtection(Timer<XMLHttpRequest>*)
(...skipping 355 matching lines...) Expand 10 before | Expand all | Expand 10 after
1242 { 1242 {
1243 return &m_eventTargetData; 1243 return &m_eventTargetData;
1244 } 1244 }
1245 1245
1246 EventTargetData* XMLHttpRequest::ensureEventTargetData() 1246 EventTargetData* XMLHttpRequest::ensureEventTargetData()
1247 { 1247 {
1248 return &m_eventTargetData; 1248 return &m_eventTargetData;
1249 } 1249 }
1250 1250
1251 } // namespace WebCore 1251 } // namespace WebCore
OLDNEW
« no previous file with comments | « LayoutTests/http/tests/xmlhttprequest/upload-request-error-event-order-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698