|
|
Chromium Code Reviews|
Created:
4 years, 6 months ago by xiaoyinh(OOO Sep 11-29) Modified:
4 years, 6 months ago Reviewers:
stevenjb CC:
chromium-reviews Base URL:
https://chromium.googlesource.com/chromium/src.git@master Target Ref:
refs/pending/heads/master Project:
chromium Visibility:
Public. |
DescriptionRoll src/third_party/cros_system_api/ 534baa06a..2f7d2849a (3 commits).
2f7d2849a expose the DBus method GetEolStatus for DBus clients
https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/534baa06a105..2f7d2849ad7d
$ git log 534baa06a..2f7d2849a --date=short --no-merges --format='%ad %ae %s'
2016-06-08 xiaoyinh Expose the update engine function GetEolStatus to dbus client
2016-05-27 jcliang dbus: power_manager: Add TABLET_MODE_{ON|OFF} protobuf definitions
2016-05-26 puthik dbus: bluetooth: Add GATT option string to match blueZ API change
BUG=611816
Committed: https://crrev.com/751212be52eee0d9a9c75160ec7894a139924500
Cr-Commit-Position: refs/heads/master@{#400201}
Patch Set 1 #Patch Set 2 : rebase the branch #Messages
Total messages: 23 (10 generated)
xiaoyinh@chromium.org changed reviewers: + stevenjb@chromium.org
stevenjb@, could you help review this? Thanks!
lgtm
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055993002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: chromeos_amd64-generic_chromium_compile_only_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_amd64-...)
Compiler error due to previous change in
1929dfe dbus: power_manager: Add TABLET_MODE_{ON|OFF} protobuf definitions
Will follow up with the auther.
Thanks!
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055993002/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-device on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...) ios-device-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-gn/bui...) ios-simulator on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...) ios-simulator-gn on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-gn/...)
The CQ bit was checked by xiaoyinh@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055993002/20001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by xiaoyinh@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from stevenjb@chromium.org Link to the patchset: https://codereview.chromium.org/2055993002/#ps20001 (title: "rebase the branch")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055993002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
CQ bit was unchecked
Message was sent while issue was closed.
Description was changed from ========== Roll src/third_party/cros_system_api/ 534baa06a..2f7d2849a (3 commits). 2f7d2849a expose the DBus method GetEolStatus for DBus clients https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/534... $ git log 534baa06a..2f7d2849a --date=short --no-merges --format='%ad %ae %s' 2016-06-08 xiaoyinh Expose the update engine function GetEolStatus to dbus client 2016-05-27 jcliang dbus: power_manager: Add TABLET_MODE_{ON|OFF} protobuf definitions 2016-05-26 puthik dbus: bluetooth: Add GATT option string to match blueZ API change BUG=611816 ========== to ========== Roll src/third_party/cros_system_api/ 534baa06a..2f7d2849a (3 commits). 2f7d2849a expose the DBus method GetEolStatus for DBus clients https://chromium.googlesource.com/chromiumos/platform/system_api.git/+log/534... $ git log 534baa06a..2f7d2849a --date=short --no-merges --format='%ad %ae %s' 2016-06-08 xiaoyinh Expose the update engine function GetEolStatus to dbus client 2016-05-27 jcliang dbus: power_manager: Add TABLET_MODE_{ON|OFF} protobuf definitions 2016-05-26 puthik dbus: bluetooth: Add GATT option string to match blueZ API change BUG=611816 Committed: https://crrev.com/751212be52eee0d9a9c75160ec7894a139924500 Cr-Commit-Position: refs/heads/master@{#400201} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/751212be52eee0d9a9c75160ec7894a139924500 Cr-Commit-Position: refs/heads/master@{#400201} |
