Revert "Fixed first step of scrolling not applying"

Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This was causing
an issue where touchpad scrolling, moving the mouse via a trackpointer, and
touchpad scrolling again caused a scroll jump because the SlaveSwitch resets
the scroll valuator but we stopped resetting the ScrollInfo's position field
with this CL.

This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.

BUG=609748, 593453
Committed: https://crrev.com/9ec3cd7e9c00b5fea3c175a404014eb32e072ec7
Cr-Commit-Position: refs/heads/master@{#399200}

[bokan, 2016-06-09 19:24:42]

Description was changed from

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This CL caused
scrolling issues when using multiple mice and the original issue it was fixing
has been solved by a follow on CL.

BUG=609748,593453
==========

to

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This CL caused
scrolling issues when using multiple mice and the original issue it was fixing
has been solved by a follow on CL.

BUG=609748,593453
==========

[bokan, 2016-06-09 19:24:43]

bokan@chromium.org changed reviewers:
+ sadrul@chromium.org

[bokan, 2016-06-09 19:28:56]

Sadrul, ptal. This was causing an issue where touchpad scrolling, moving the
mouse via a trackpointer, and touchpad scrolling again caused a scroll jump
because the SlaveSwitch resets the scroll valuator but we stopped resetting the
ScrollInfo's position field with this CL.

This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.

[sadrul, 2016-06-10 14:50:03]

lgtm

[bokan, 2016-06-10 14:50:26]

The CQ bit was checked by bokan@chromium.org

[sadrul, 2016-06-10 14:50:39]

On 2016/06/10 14:50:03, sadrul wrote:
> lgtm

Can you include please your comment in the CL description?

[commit-bot: I haz the power, 2016-06-10 14:50:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/2055913002/1

[bokan, 2016-06-10 14:52:30]

Description was changed from

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This CL caused
scrolling issues when using multiple mice and the original issue it was fixing
has been solved by a follow on CL.

BUG=609748,593453
==========

to

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This was causing
an issue where touchpad scrolling, moving the mouse via a trackpointer, and
touchpad scrolling again caused a scroll jump because the SlaveSwitch resets
the scroll valuator but we stopped resetting the ScrollInfo's position field
with this CL.

This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.

BUG=609748,593453
==========

[bokan, 2016-06-10 14:52:38]

On 2016/06/10 14:50:39, sadrul wrote:
> On 2016/06/10 14:50:03, sadrul wrote:
> > lgtm
> 
> Can you include please your comment in the CL description?

done.

[commit-bot: I haz the power, 2016-06-10 16:12:43]

Description was changed from

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This was causing
an issue where touchpad scrolling, moving the mouse via a trackpointer, and
touchpad scrolling again caused a scroll jump because the SlaveSwitch resets
the scroll valuator but we stopped resetting the ScrollInfo's position field
with this CL.

This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.

BUG=609748,593453
==========

to

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This was causing
an issue where touchpad scrolling, moving the mouse via a trackpointer, and
touchpad scrolling again caused a scroll jump because the SlaveSwitch resets
the scroll valuator but we stopped resetting the ScrollInfo's position field
with this CL.

This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.

BUG=609748,593453
==========

[commit-bot: I haz the power, 2016-06-10 16:12:44]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2016-06-10 16:12:50]

CQ bit was unchecked

[commit-bot: I haz the power, 2016-06-10 16:14:30]

Description was changed from

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This was causing
an issue where touchpad scrolling, moving the mouse via a trackpointer, and
touchpad scrolling again caused a scroll jump because the SlaveSwitch resets
the scroll valuator but we stopped resetting the ScrollInfo's position field
with this CL.

This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.

BUG=609748,593453
==========

to

==========
Revert "Fixed first step of scrolling not applying"

This reverts commit 47c6f3e7252ece9b52e5b86d40944e66442ea7aa. This was causing
an issue where touchpad scrolling, moving the mouse via a trackpointer, and
touchpad scrolling again caused a scroll jump because the SlaveSwitch resets
the scroll valuator but we stopped resetting the ScrollInfo's position field
with this CL.

This CL was originally meant to address issue 593453, where a first tick of a
scroll wouldn't apply because the SlaveSwitch cleared out the ScrollInfo fields
but that should be addressed by Will's second CL in that issue:
https://codereview.chromium.org/1792623003 which disables xinput2 for
non-precise devices.

BUG=609748,593453

Committed: https://crrev.com/9ec3cd7e9c00b5fea3c175a404014eb32e072ec7
Cr-Commit-Position: refs/heads/master@{#399200}
==========

[commit-bot: I haz the power, 2016-06-10 16:14:31]

Patchset 1 (id:??) landed as
https://crrev.com/9ec3cd7e9c00b5fea3c175a404014eb32e072ec7
Cr-Commit-Position: refs/heads/master@{#399200}