[Draft] Fix canceling pin prompt causes host overload

remoting/protocol/session.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_SESSION_H_
 #define REMOTING_PROTOCOL_SESSION_H_
 
 #include <string>
 
 #include "remoting/protocol/errors.h"
@@ skipping 51 matching lines @@
     // |channel_name| changes. Session must not be destroyed by the
     // handler of this event.
     virtual void OnSessionRouteChange(const std::string& channel_name,
                                       const TransportRoute& route) = 0;
 
     // Called when ready state on one of the channels changes. See
     // comments in transport.h for explanation on what this state
     // means and how it can used.
     virtual void OnSessionChannelReady(const std::string& channel_name,
                                        bool ready) {}
+
+    // Called when the session begins authentication
+    virtual void OnSessionAuthenticationBegin() {};

[Sergey Ulanov, 2014/03/24 18:42:36]

Instead of adding this callback I think it would be cleaner to have another
state between CONNECTED and AUTHENTICATED.

[Sergey Ulanov, 2014/03/24 18:42:36]

If you keep this method: s/Begin/Started/ for consistency.

[kelvinp, 2014/03/24 23:11:39]

Done.

[kelvinp, 2014/03/24 23:11:39]

I have added the extra state instead

   };
 
 
   Session() {}
   virtual ~Session() {}
 
   // Set event handler for this session. |event_handler| must outlive
   // this object.
   virtual void SetEventHandler(EventHandler* event_handler) = 0;
 
@@ skipping 29 matching lines @@
   virtual void Close() = 0;
 
  private:
   DISALLOW_COPY_AND_ASSIGN(Session);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_SESSION_H_