[Draft] Fix canceling pin prompt causes host overload

remoting/protocol/fake_authenticator.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef REMOTING_PROTOCOL_FAKE_AUTHENTICATOR_H_
 #define REMOTING_PROTOCOL_FAKE_AUTHENTICATOR_H_
 
 #include "base/callback.h"
 #include "base/memory/weak_ptr.h"
 #include "remoting/protocol/authenticator.h"
@@ skipping 40 matching lines @@
     HOST,
     CLIENT,
   };
 
   enum Action {
     ACCEPT,
     REJECT,
     REJECT_CHANNEL
   };
 
+  FakeAuthenticator(Type type, int round_trips, int messages_till_started,

[Sergey Ulanov, 2014/04/02 19:49:26]

It's better to avoid function overloading:
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml#Function_Overl...

I suggest adding set_message_till_started().

+                    Action action, bool async);
   FakeAuthenticator(Type type, int round_trips, Action action, bool async);
+
   virtual ~FakeAuthenticator();
 
   // Authenticator interface.
   virtual State state() const OVERRIDE;
+  virtual bool started() const OVERRIDE;
   virtual RejectionReason rejection_reason() const OVERRIDE;
   virtual void ProcessMessage(const buzz::XmlElement* message,
                               const base::Closure& resume_callback) OVERRIDE;
   virtual scoped_ptr<buzz::XmlElement> GetNextMessage() OVERRIDE;
   virtual scoped_ptr<ChannelAuthenticator>
       CreateChannelAuthenticator() const OVERRIDE;
 
  protected:
   Type type_;
   int round_trips_;
   Action action_;
   bool async_;
 
   // Total number of messages that have been processed.
   int messages_;
+  // Number of messages that the authenticator needs to process before started()
+  // returns true.  Default to 0

[Sergey Ulanov, 2014/04/02 19:49:26]

nit: add '.' at the end of the comment

[kelvinp, 2014/04/07 18:48:01]

Done.

+  int messages_till_started_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeAuthenticator);
 };
 
 class FakeHostAuthenticatorFactory : public AuthenticatorFactory {
  public:
   FakeHostAuthenticatorFactory(
-      int round_trips, FakeAuthenticator::Action action, bool async);
+      int round_trips, int messages_till_start,
+      FakeAuthenticator::Action action, bool async);
   virtual ~FakeHostAuthenticatorFactory();
 
   // AuthenticatorFactory interface.
   virtual scoped_ptr<Authenticator> CreateAuthenticator(
       const std::string& local_jid,
       const std::string& remote_jid,
       const buzz::XmlElement* first_message) OVERRIDE;
 
  private:
   int round_trips_;
+  int messages_till_started_;
   FakeAuthenticator::Action action_;
   bool async_;
 
   DISALLOW_COPY_AND_ASSIGN(FakeHostAuthenticatorFactory);
 };
 
 }  // namespace protocol
 }  // namespace remoting
 
 #endif  // REMOTING_PROTOCOL_FAKE_AUTHENTICATOR_H_