Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issue 205583009: Remove VideoTrack runtime feature since we always support TextTracks. (Closed)

Created:
6 years, 9 months ago by acolwell GONE FROM CHROMIUM
Modified:
6 years, 8 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, nessy, arv+blink, gasubic, fs, eric.carlson_apple.com, watchdog-blink-watchlist_google.com, feature-media-reviews_chromium.org, dglazkov+blink, adamk+blink_chromium.org, vcarbune.chromium, Inactive
Visibility:
Public.

Description

Remove VideoTrack runtime feature since we always support TextTracks. We haven't built Chrome without TextTrack support for a long time so I'm removing the VideoTrack feature flag and removing all conditional code that depended on it. It is part of the HTML5 spec and should be on by default for any compliant implementation that supports media. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170680

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -71 lines) Patch
M Source/core/html/HTMLMediaElement.cpp View 1 2 19 chunks +21 lines, -51 lines 0 comments Download
M Source/core/html/HTMLMediaElement.idl View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/html/HTMLTagNames.in View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTrackElement.idl View 1 2 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/track/TextTrack.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/track/TextTrackCue.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TextTrackCueList.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/track/TextTrackList.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/track/TrackEvent.idl View 1 chunk +1 line, -3 lines 0 comments Download
M Source/core/html/track/vtt/VTTCue.idl View 1 chunk +0 lines, -1 line 0 comments Download
M Source/platform/RuntimeEnabledFeatures.in View 1 2 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 18 (0 generated)
acolwell GONE FROM CHROMIUM
6 years, 9 months ago (2014-03-21 21:08:52 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-21 21:15:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/205583009/1
6 years, 9 months ago (2014-03-21 21:16:01 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 21:16:24 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_rel
6 years, 9 months ago (2014-03-21 21:16:25 UTC) #5
acolwell GONE FROM CHROMIUM
On 2014/03/21 21:16:25, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 9 months ago (2014-03-21 21:45:48 UTC) #6
acolwell GONE FROM CHROMIUM
Created https://codereview.chromium.org/208953004/ to fix Events.cpp regeneration.
6 years, 9 months ago (2014-03-21 22:15:30 UTC) #7
philipj_slow
Off topic: This makes the Media runtime feature even stranger. When I've tried to remove ...
6 years, 9 months ago (2014-03-23 13:04:53 UTC) #8
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-27 00:09:49 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/205583009/1
6 years, 9 months ago (2014-03-27 00:09:55 UTC) #10
acolwell GONE FROM CHROMIUM
The CQ bit was unchecked by acolwell@chromium.org
6 years, 9 months ago (2014-03-27 00:15:15 UTC) #11
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 9 months ago (2014-03-27 00:16:29 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/205583009/20001
6 years, 9 months ago (2014-03-27 00:16:36 UTC) #13
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-27 00:26:46 UTC) #14
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on mac_blink_compile_dbg
6 years, 9 months ago (2014-03-27 00:26:47 UTC) #15
acolwell GONE FROM CHROMIUM
The CQ bit was checked by acolwell@chromium.org
6 years, 8 months ago (2014-04-02 17:13:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/acolwell@chromium.org/205583009/40001
6 years, 8 months ago (2014-04-02 17:14:21 UTC) #17
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 18:58:58 UTC) #18
Message was sent while issue was closed.
Change committed as 170680

Powered by Google App Engine
This is Rietveld 408576698