Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(353)

Issue 205583005: Introduce String and AtomicString size check (Closed)

Created:
6 years, 9 months ago by Mikhail
Modified:
6 years, 9 months ago
CC:
blink-reviews, Mikhail, adamk+blink_chromium.org, Inactive, abarth-chromium, eseidel
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Introduce String and AtomicString size check SSIA. Considering the memory sensitiveness of strings in Blink we should make sure that no change can accidentally increase their size. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=169750

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M Source/wtf/SizeLimits.cpp View 2 chunks +4 lines, -0 lines 1 comment Download

Messages

Total messages: 9 (0 generated)
Mikhail
PTAL
6 years, 9 months ago (2014-03-21 16:29:26 UTC) #1
eseidel
lgtm
6 years, 9 months ago (2014-03-21 16:41:14 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/205583005/1
6 years, 9 months ago (2014-03-21 16:41:16 UTC) #3
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 9 months ago (2014-03-21 16:48:29 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 9 months ago (2014-03-21 16:48:30 UTC) #5
abarth-chromium
https://codereview.chromium.org/205583005/diff/1/Source/wtf/SizeLimits.cpp File Source/wtf/SizeLimits.cpp (right): https://codereview.chromium.org/205583005/diff/1/Source/wtf/SizeLimits.cpp#newcode84 Source/wtf/SizeLimits.cpp:84: COMPILE_ASSERT(sizeof(AtomicString) == sizeof(String), AtomicString_should_stay_small); We already have this compile ...
6 years, 9 months ago (2014-03-21 17:12:22 UTC) #6
abarth-chromium
The CQ bit was checked by abarth@chromium.org
6 years, 9 months ago (2014-03-21 17:12:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mikhail.pozdnyakov@intel.com/205583005/1
6 years, 9 months ago (2014-03-21 17:12:32 UTC) #8
commit-bot: I haz the power
6 years, 9 months ago (2014-03-21 17:48:33 UTC) #9
Message was sent while issue was closed.
Change committed as 169750

Powered by Google App Engine
This is Rietveld 408576698