Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(356)

Issue 2055823004: telemetry: Update tough_path_rendering_cases Chalkboard test URL (Closed)

Created:
4 years, 6 months ago by Stephen White
Modified:
4 years, 6 months ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

telemetry: Update tough_path_rendering_cases Chalkboard test URL [Copy of https://codereview.chromium.org/1998543002/ by kkinnunen@nvidia.org with the WPR uploaded.] Update tough_path_rendering_cases Chalkboard test URL. The old url would go to a page that would load the content in an iframe. The injected script would fail. Load the iframe URL instead. Loading the main document would inject the script to the parent main document. The injected code would start the test by click()ing an element cross domains, which would be rejected. Fixing is needed in order to record new content to tough_path_rendering_cases. BUG=594928 Committed: https://crrev.com/d0d9b578d0fce1a364f157c6cd669fd4439a916a Cr-Commit-Position: refs/heads/master@{#398985}

Patch Set 1 #

Total comments: 2

Patch Set 2 : Fix formatting #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -3 lines) Patch
M tools/perf/page_sets/data/tough_path_rendering_cases.json View 1 chunk +5 lines, -2 lines 0 comments Download
A tools/perf/page_sets/data/tough_path_rendering_cases_001.wpr.sha1 View 1 chunk +1 line, -0 lines 0 comments Download
M tools/perf/page_sets/tough_path_rendering_cases.py View 1 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055823004/1
4 years, 6 months ago (2016-06-09 18:26:24 UTC) #2
Stephen White
nednguyen@: PTAL. Thanks!
4 years, 6 months ago (2016-06-09 18:27:28 UTC) #6
nednguyen
lgtm https://codereview.chromium.org/2055823004/diff/1/tools/perf/page_sets/tough_path_rendering_cases.py File tools/perf/page_sets/tough_path_rendering_cases.py (right): https://codereview.chromium.org/2055823004/diff/1/tools/perf/page_sets/tough_path_rendering_cases.py#newcode41 tools/perf/page_sets/tough_path_rendering_cases.py:41: # Chalkboard content linked from http://ie.microsoft.com/testdrive/Performance/Chalkboard/. nits: split ...
4 years, 6 months ago (2016-06-09 18:33:35 UTC) #7
Stephen White
Thanks for your review. https://codereview.chromium.org/2055823004/diff/1/tools/perf/page_sets/tough_path_rendering_cases.py File tools/perf/page_sets/tough_path_rendering_cases.py (right): https://codereview.chromium.org/2055823004/diff/1/tools/perf/page_sets/tough_path_rendering_cases.py#newcode41 tools/perf/page_sets/tough_path_rendering_cases.py:41: # Chalkboard content linked from ...
4 years, 6 months ago (2016-06-09 18:36:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/2055823004/20001
4 years, 6 months ago (2016-06-09 18:37:54 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 6 months ago (2016-06-09 19:53:38 UTC) #13
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/d0d9b578d0fce1a364f157c6cd669fd4439a916a Cr-Commit-Position: refs/heads/master@{#398985}
4 years, 6 months ago (2016-06-09 19:55:13 UTC) #15
Stephen White
4 years, 6 months ago (2016-06-09 19:59:02 UTC) #16
Message was sent while issue was closed.
NOTE TO PERF SHERIFFS: the change in URL may impact the results of the
Chalkboard test (either negatively or positively). However, it should affect the
ref build as well, so the change should be ignored.

Powered by Google App Engine
This is Rietveld 408576698