chrome/browser/resources/settings/site_settings/site_settings_behavior.js - Issue 2055823003: Site Settings Desktop: Implement the 'Clear on exit' menu for Cookies.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

Issue 2055823003: Site Settings Desktop: Implement the 'Clear on exit' menu for Cookies. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Polish Created 4 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/settings/site_settings/site_list.js ('k') | chrome/browser/resources/settings/site_settings/site_settings_category.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/settings/site_settings/site_settings_behavior.js

diff --git a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

index 5d9e2f60daa57630e3b3f8495b99b1a9ebad3f41..793e9afcb93bef8cd6c6b37aa7faad330df51272 100644

--- a/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

+++ b/chrome/browser/resources/settings/site_settings/site_settings_behavior.js

@@ -28,6 +28,10 @@ var SiteSettingsBehaviorImpl = {

settings.SiteSettingsPrefsBrowserProxyImpl.getInstance();

+ attached: function() {

+ this.PermissionValues = settings.PermissionValues;

michaelpg 2016/06/13 15:54:38 Why attached instead of ready? (I would be worried

Finnur 2016/06/16 13:53:10 When I implemented this initially, something didn'

+ },

/**

* Re-sets the category permission for a given origin.

* @param {string} primaryPattern The primary pattern to reset the permission