Site Settings Desktop: Implement the 'Clear on exit' menu for Cookies.

chrome/browser/resources/settings/site_settings/site_settings_behavior.js

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Behavior common to Site Settings classes.
  */
 
 /** @polymerBehavior */
 var SiteSettingsBehaviorImpl = {
@@ skipping 10 matching lines @@
      * @type {settings.SiteSettingsPrefsBrowserProxyImpl}
      */
     browserProxy: Object,
   },
 
   created: function() {
     this.browserProxy =
         settings.SiteSettingsPrefsBrowserProxyImpl.getInstance();
   },
 
+  attached: function() {
+    this.PermissionValues = settings.PermissionValues;

[michaelpg, 2016/06/13 15:54:38]

Why attached instead of ready? (I would be worried we would use this somewhere
after ready but before attached, but I guess that's not happening?)

[Finnur, 2016/06/16 13:53:10]

When I implemented this initially, something didn't work when this was set in
ready(), but I can't seem to find anything broken now -- so I changed it to
ready.

+  },
+
   /**
    * Re-sets the category permission for a given origin.
    * @param {string} primaryPattern The primary pattern to reset the permission
    *     for.
    * @param {string} secondaryPattern The secondary pattern to reset the
    *     permission for.
    * @param {string} category The category permission to change.
    * @protected
    */
   resetCategoryPermissionForOrigin: function(
@@ skipping 322 matching lines @@
    * @private
    */
   computeSiteIcon: function(site) {
     var url = this.ensureUrlHasScheme(site.originForDisplay);
     return 'background-image: ' + cr.icon.getFaviconImageSet(url);
   },
 };
 
 /** @polymerBehavior */
 var SiteSettingsBehavior = [SiteSettingsBehaviorImpl];